Skip to content

Commit 6e1a713

Browse files
denikIsaac
andcommitted
Drop repro test scaffolding, keep the declarative fix
Remove the acceptance test and the testserver trace_location injection. The injection was a name-scoped scaffold, not a proven model of backend behaviour, so it does not belong in the fake workspace. The fix is the declarative backend_defaults entry on experiments.yml, covered by the dresources classifier tests. Co-authored-by: Isaac <[email protected]>
1 parent 09a8e18 commit 6e1a713

6 files changed

Lines changed: 0 additions & 109 deletions

File tree

‎acceptance/bundle/resources/experiments/uc-tracing-recreate/databricks.yml‎

Lines changed: 0 additions & 10 deletions
This file was deleted.

‎acceptance/bundle/resources/experiments/uc-tracing-recreate/out.test.toml‎

Lines changed: 0 additions & 3 deletions
This file was deleted.

‎acceptance/bundle/resources/experiments/uc-tracing-recreate/output.txt‎

Lines changed: 0 additions & 47 deletions
This file was deleted.

‎acceptance/bundle/resources/experiments/uc-tracing-recreate/script‎

Lines changed: 0 additions & 21 deletions
This file was deleted.

‎acceptance/bundle/resources/experiments/uc-tracing-recreate/test.toml‎

Lines changed: 0 additions & 9 deletions
This file was deleted.

‎libs/testserver/experiments.go‎

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,6 @@ import (
1010
"github.com/databricks/databricks-sdk-go/service/ml"
1111
)
1212

13-
// experimentNameUCTracing scopes the out-of-band UC trace-location injection to the
14-
// recreate repro test, keeping unrelated experiment tests free of it. Mirrors
15-
// catalogNameManagedDefaults. It mimics an enable-UC-tracing job that binds a trace
16-
// location to the experiment after creation, one the bundle config never declares.
17-
const experimentNameUCTracing = "uc-tracing"
18-
1913
func (s *FakeWorkspace) ExperimentCreate(req Request) Response {
2014
defer s.LockUnlock()()
2115

@@ -81,19 +75,6 @@ func (s *FakeWorkspace) ExperimentCreate(req Request) Response {
8175
TraceLocation: experiment.TraceLocation,
8276
}
8377

84-
// Mimic an out-of-band enable-UC-tracing job: the bundle config never declares
85-
// trace_location, but GetExperiment then echoes one. See SUP-37168 and
86-
// acceptance/bundle/resources/experiments/uc-tracing-recreate.
87-
if exp.TraceLocation == nil && strings.Contains(experimentName, experimentNameUCTracing) {
88-
exp.TraceLocation = &ml.ExperimentTraceLocation{
89-
UcTraceLocation: &ml.UcTraceLocation{
90-
Catalog: "main",
91-
Schema: "traces",
92-
EffectiveTablePrefix: "exp_" + experimentId + "_traces",
93-
},
94-
}
95-
}
96-
9778
s.Experiments[experimentId] = ml.GetExperimentResponse{
9879
Experiment: &exp,
9980
}

0 commit comments

Comments
 (0)