Don't call removeReverseDep on a non-incremental node entry in tests.

justinhorvitz · pull[bot] · commit 344973841164 · 2023-09-29T10:08:05.000Z
It's illegal. There must be some race in propagating the failure from the async thread since the test is only flakily failing since bazelbuild@20c541c (albeit at a very high rate). PiperOrigin-RevId: 556074380 Change-Id: I6c177d0346cb9849b5aa81c104ad9295548f5a84
diff --git a/src/test/java/com/google/devtools/build/skyframe/GraphTest.java b/src/test/java/com/google/devtools/build/skyframe/GraphTest.java
@@ -260,7 +260,9 @@ public void testAddRemoveRdeps() throws Exception {
               waitForAddedRdep.countDown();
               waitForSetValue.await(TestUtils.WAIT_TIMEOUT_SECONDS, SECONDS);
               for (int k = chunkSize; k <= numIterations; k++) {
-                entry.removeReverseDep(key("rdep" + j));
+                if (shouldTestIncrementality()) {
+                  entry.removeReverseDep(key("rdep" + j));
+                }
                 entry.addReverseDepAndCheckIfDone(key("rdep" + j));
                 if (shouldTestIncrementality()) {
                   entry.getReverseDepsForDoneEntry();
