Skip to content

Fixed backend recursion bug#396

Merged
zack-soenen merged 3 commits intomasterfrom
fix-backend-recursion
Nov 13, 2020
Merged

Fixed backend recursion bug#396
zack-soenen merged 3 commits intomasterfrom
fix-backend-recursion

Conversation

@dvdjlaw
Copy link
Copy Markdown
Member

@dvdjlaw dvdjlaw commented Nov 11, 2020

Fixes #384

Opens #397 as follow-up

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 11, 2020

Codecov Report

Merging #396 (449e020) into master (b8b2cba) will increase coverage by 0.43%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #396      +/-   ##
==========================================
+ Coverage   90.58%   91.01%   +0.43%     
==========================================
  Files          41       41              
  Lines        1826     1880      +54     
==========================================
+ Hits         1654     1711      +57     
+ Misses        172      169       -3     
Impacted Files Coverage Δ
data_describe/backends/_backends.py 80.00% <100.00%> (+2.00%) ⬆️
data_describe/core/summary.py 96.55% <0.00%> (+4.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fe3a11...449e020. Read the comment docs.

@dvdjlaw dvdjlaw changed the title Fixed backend recursion Fixed backend recursion bug Nov 13, 2020
Copy link
Copy Markdown
Collaborator

@zack-soenen zack-soenen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zack-soenen zack-soenen merged commit ed55cb9 into master Nov 13, 2020
@zack-soenen zack-soenen deleted the fix-backend-recursion branch November 13, 2020 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Backend module raises RecursionError when no implemention is found

2 participants