Conversation
Codecov Report
@@ Coverage Diff @@
## master #386 +/- ##
=======================================
Coverage 90.58% 90.58%
=======================================
Files 41 41
Lines 1826 1826
=======================================
Hits 1654 1654
Misses 172 172
Continue to review full report at Codecov.
|
dvdjlaw
requested changes
Nov 9, 2020
Member
dvdjlaw
left a comment
dvdjlaw
left a comment
There was a problem hiding this comment.
In addition to addressing the kwargs for filter_extremes, please also:
- Update the title as it will be used in release notes (past tense, more descriptive of what changed)
- Add the proper label (bug) as it will be used in release notes
| Default is 10. | ||
| no_above: Keep tokens which are contained in no more than no_above portion of | ||
| documents (fraction of total corpus size). Default is 0.2. | ||
| **kwargs: Other arguments to be passed to gensim.corpora.Dictionary.filter_extremes |
Member
There was a problem hiding this comment.
Forgot to use the kwargs in this func
truongc2
changed the title
truongc2
changed the title
dvdjlaw
approved these changes
Nov 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #381
Added **kwargs to filter_dictionary, create_doc_term_matrix, and create_tfidf_matrix in text_preprocessing.py