Nit: clarify s & axes in FFT docs#746
Merged
kgryte merged 5 commits intodata-apis:mainfrom Feb 14, 2024
Merged
Conversation
Member
|
Does this text match what is used elsewhere? I would word it more like "if axes contains multiple entries referring to the same dimension..." or something like that, since a positive and negative axis can refer to the same dimension but not actually be a "repeated entry". |
Contributor
Author
|
That's a good point. No, as I noted in #747 I think this is the very first time that we've ever cared about (effectively) repeating axes in the standard. I'll update. |
Member
|
The other functions with
|
kgryte
reviewed
Feb 13, 2024
kgryte
reviewed
Feb 13, 2024
kgryte
reviewed
Feb 13, 2024
kgryte
reviewed
Feb 13, 2024
kgryte
reviewed
Feb 13, 2024
kgryte
reviewed
Feb 13, 2024
kgryte
reviewed
Feb 13, 2024
kgryte
reviewed
Feb 13, 2024
kgryte
reviewed
Feb 13, 2024
kgryte
reviewed
Feb 13, 2024
kgryte
reviewed
Feb 13, 2024
kgryte
reviewed
Feb 13, 2024
kgryte
reviewed
Feb 13, 2024
kgryte
reviewed
Feb 13, 2024
kgryte
reviewed
Feb 13, 2024
kgryte
reviewed
Feb 13, 2024
kgryte
reviewed
Feb 13, 2024
kgryte
reviewed
Feb 13, 2024
kgryte
reviewed
Feb 13, 2024
kgryte
reviewed
Feb 13, 2024
kgryte
reviewed
Feb 13, 2024
kgryte
reviewed
Feb 13, 2024
kgryte
reviewed
Feb 13, 2024
kgryte
reviewed
Feb 13, 2024
kgryte
reviewed
Feb 13, 2024
kgryte
reviewed
Feb 13, 2024
Contributor
|
Thanks, @leofang! If the suggestions are good for you, this should be ready for merge after resolution. |
Co-authored-by: Athan <[email protected]>
Contributor
Author
|
Thanks, @kgryte, suggestions applied. |
kgryte
reviewed
Feb 14, 2024
kgryte
reviewed
Feb 14, 2024
kgryte
approved these changes
Feb 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
imeaning in the docstrings involvingsaxesaxeshas repeated entries, the behavior is undefined (close RFC: Explicit forbid any axes being repeated in theaxesof the multi-dimensional FFT APIs? #747)