Allow negative axes in tensordot#625
Merged
kgryte merged 2 commits intodata-apis:mainfrom Sep 20, 2023
Merged
Conversation
Both NumPy and PyTorch allow this, and there should be no ambiguity or difficulty in doing so, as long as the specified axes remain unique.
kgryte
added
API change
This follows precedent elsewhere (e.g., `moveaxis`).
kgryte
approved these changes
Sep 20, 2023
Contributor
|
As this PR introduces changes which are consistent with guidance elsewhere in the specification (namely, a valid axis index may be negative, resolving to a positive index according to For reference, the original PR makes no mention regarding the original guidance of nonnegative integers. That the guidance required nonnegative integers and not negative integers was likely an omission/mistake. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both NumPy and PyTorch allow this, and there should be no ambiguity or difficulty in doing so, as long as the specified axes remain unique.