Fix mistake in description of return dtype for matrix_rank#510
Merged
kgryte merged 1 commit intodata-apis:mainfrom Nov 16, 2022
Merged
Fix mistake in description of return dtype for matrix_rank#510kgryte merged 1 commit intodata-apis:mainfrom
matrix_rank#510kgryte merged 1 commit intodata-apis:mainfrom
Conversation
This was a simple mistake, not discussed in the review for the PR that added `matrix_rank` (data-apisgh-128). Closes data-apisgh-469
rgommers
added
Maintenance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a simple mistake, not discussed in the review for the PR that added
matrix_rank(gh-128).Closes gh-469