Add support for specifying the output array dtype in linalg.trace#502
Merged
Add support for specifying the output array dtype in linalg.trace#502
linalg.trace#502Conversation
Contributor
Author
|
Based on the 3 November 2022 meeting, no objections were raised to the changes introduced in this PR. Will keep open for another week to allow further comment. |
Contributor
Author
|
As the changes introduced in this PR follow the same guidance as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
dtypekwarg and specifying promotion rules for the output array dtype.N = 0and when an element isNaN, as done forsum.