iinfo() and finfo() result holds dtype attribute#485
Merged
leofang merged 2 commits intodata-apis:mainfrom Oct 17, 2022
Merged
Conversation
honno
changed the title
finfo() result holds dtype attributeiinfo() and finfo() result holds dtype attribute
Member
honno
force-pushed
the
finfo-dtype-attr
branch
from
cb6aa80 to
7f15301
Compare
leofang
approved these changes
Oct 17, 2022
oleksandr-pavlyk
approved these changes
Oct 17, 2022
Contributor
oleksandr-pavlyk
left a comment
oleksandr-pavlyk
left a comment
There was a problem hiding this comment.
Thanks for adding this!
Contributor
|
Merged since this was approved in the meeting and we gathered two green checks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In yesterdays meeting @oleksandr-pavlyk bought up that NumPy's
iinfo()/finfo()returns info objects with adtypeattribute.There seemed to be no objections, but it turns outResolved in numpy/numpy#22334dtypewasn't actually document for NumPy...I've left this PR separate from #484 to keep things atomic, incase things become finicky. It depends on that PR because of the subtle distinction I made inThat was merged, so happy with this PR on my end!finfo()to clarify attributes relate to real-valued floats... just want that to resolve (i.e. be merged) first.