Clarify the required semantics for broadcasting with __setitem__#429
Merged
rgommers merged 2 commits intodata-apis:mainfrom Nov 17, 2022
Merged
Clarify the required semantics for broadcasting with __setitem__#429rgommers merged 2 commits intodata-apis:mainfrom
__setitem__#429rgommers merged 2 commits intodata-apis:mainfrom
Conversation
Contributor
|
Can we add two simple examples to illustrate what's allowed and what's not? |
Contributor
|
@asmeurer Would you be willing to update this PR with two examples, one illustrating what is allowed and another illustrating what is disallowed? |
Member
Author
|
Added. |
rgommers
changed the title
__setitem__
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #424.
I have used SHOULD here as suggested in the consortium meeting to not disallow NumPy-like "reverse broadcasting" semantics.