Update the default axis value for vecdot to be -1#281
Merged
Conversation
kgryte
added
API change
asmeurer
approved these changes
Oct 4, 2021
Contributor
Author
|
As this has been approved, merging... |
kgryte
changed the title
axis default for vecdot to be -1axis value for vecdot to be -1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
axisdefault fromNoneto-1. Behavior is still preserved, in that, by default, the function computes the vector dot product over the last dimension.Nonewas probably never intended, given that its associated behavior is equivalent toaxis=-1.