Require single-axis indexing expressions be provided for each axis#272
Merged
Require single-axis indexing expressions be provided for each axis#272
Conversation
kgryte
added
API change
Contributor
Author
|
As this was discussed and agreed upon in consortium meetings, will go ahead and merge. And refinements/changes can be made in subsequent PRs. |
asmeurer
reviewed
Oct 7, 2021
| - Providing [ellipsis](https://docs.python.org/3/library/constants.html#Ellipsis) must apply `:` to each dimension necessary to index all dimensions (e.g., if `A` has rank `4`, `A[1:, ..., 2:5] == A[1:, :, :, 2:5]`). Only a single ellipsis must be allowed. An `IndexError` exception must be raised if more than one ellipsis is provided. | ||
|
|
||
| - An `IndexError` exception must be raised if the number of provided single-axis indexing expressions is greater than `N`. | ||
| - Except in the case of providing an ellipsis to index all trailing dimensions (e.g., `A[2:10, ...]`), the number of provided single-axis indexing expressions must equal `N`. For example, if `A` has rank `2`, a single-axis indexing expression must be explicitly provided for both axes (e.g., `A[2:10, :]`). An `IndexError` exception must be raised if the number of provided single-axis indexing expressions is less than `N`. |
Member
There was a problem hiding this comment.
Just noticed the word "trailing" should not be here. An ellipsis can go anywhere in the index, not just at the end.
Member
There was a problem hiding this comment.
Also shouldn't this be "should" instead of "must"? Do we want to require this restriction or just limit what the spec requires?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR