Enhanced thread-safety in zict.File #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crusaderky
force-pushed
the
File_threadsafe
branch
from
3322030 to
9308dc7
Compare
crusaderky
force-pushed
the
File_threadsafe
branch
from
9308dc7 to
5b5de92
Compare
crusaderky
changed the title
crusaderky
commented
Mar 21, 2023
| assert f1.result() > 100 | ||
| assert f2.result() > 100 | ||
|
|
||
| assert not z |
Collaborator
Author
There was a problem hiding this comment.
I tried writing a test for concurrency on the same key, with a single producer/destroyer and multiple consumers/destroyers, but I gave up. The reason is that the only way a consumer can grab a key while it's being overwritten over and over is that it accidentally hits the spot between iterations of __setitem__, which is extremely hard.
Merged
milesgranger
approved these changes
Mar 22, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zict.Fileis now almost fully thread-safe, with the only caveat that you can't call__setitem__on the same key at the same time from two different threads. Crucially for dask/distributed#4424, you can now delete a key from the main thread while the same key is being either read or written from an offloaded thread.