LRU callbacks may raise #47
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks @crusaderky , I'll pick it up from here. |
This was referenced Nov 23, 2021
Merged
crusaderky
commented
Nov 24, 2021
Comment on lines
+64
to
+65
| while self.total_weight > self.n: | ||
| self.evict() |
Collaborator
Author
There was a problem hiding this comment.
There are 3 use cases:
- weight <= self.n. In this case, the while loop is guaranteed to stop before key is evicted.
- weight > self.n and the sum of all other keys in self.d is enough to fill slow. so you will raise on line 72 and again on again on line 65 at some point in the middle of the while iteration. This is desirable.
- weight > self.n and the sum of all other keys fits in slow. The while won't stop until it tries and - we know in advance - fail to store key too into slow. This can be avoided with the following:
Suggested change
| while self.total_weight > self.n: | |
| self.evict() | |
| while self.total_weight > self.n and len(self.d) > 1: | |
| self.evict() |
Collaborator
Author
|
Superseded by #48 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an LRU on_evict callback raises an exception, e.g. out of disk space, keep the key in memory instead of accidentally losing it.
Completely untested.
@ncclementi could you pick this up from here?