schema: Memory thresholds should never be exactly 0.0. #7458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead, config should use 'false' to disable memory management
Member
|
Hi @stuarteberg 👋 @crusaderky I suspect that you understand this topic better than I do. Would you be comfortable owning this issue? |
Collaborator
|
This makes sense to me. It avoids us having to set up over-complicated use case tests between 0 and False. |
crusaderky
approved these changes
Jan 6, 2023
Member
Author
|
@crusaderky The CI has sporadic failures, but I think they're unrelated to this change. I'm not sure if there's anything else to do in this PR. (Do schema changes require unit tests?) Unless you have any suggestions, I think this is good for review/merge. |
Member
|
Thanks @stuarteberg ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the config, memory thresholds such as
distributed.worker.memory.terminateshould never be exactly0.0.Instead, config should use
falseto disable memory management.This one bit me recently. My older dask config files used
0.0to disable the memory management features. That worked because older versions ofdistributedinterpreted the value0.0to be equivalent tofalsefor these fields. But in newer versions, onlyfalseworks. (I suspect the change occurred in #5904.)Nowadays, if the config says
0.0, thendistributedinterprets that literally -- and no memory can be used at all without incurring the wrath of the memory manager!An easy "fix" is to disallow
0.0in the user's config. In json schema,exclusiveMinimum: 0ensures that the value0.0itself is not permitted by the schema.pre-commit run --all-files