Don't invoke log_event from state machine #6512
Conversation
crusaderky
changed the title
Unit Test Results 15 files ±0 15 suites ±0 6h 33m 47s ⏱️ + 2m 53s For more details on these failures, see this check. Results for commit ef12618. ± Comparison against base commit bd98e66. ♻️ This comment has been updated with latest results. |
|
|
||
| del s.events["invalid-worker-transition"] # for test cleanup | ||
|
|
||
|
|
There was a problem hiding this comment.
Duplicates test in test_utils_test.py
|
Ready for final review and merge |
| if isinstance(msg, dict): | ||
| msg["worker"] = worker |
There was a problem hiding this comment.
I'm curious, why this change?
For context, this tripped me up when doing some Coiled work. I'm not against it, I'm just curious about the motivation.
There was a problem hiding this comment.
Previously, the same info was manually added to most worker-side calls to log-event. Adding it when it lands looks cleaner and less redundant.
There was a problem hiding this comment.
Users can use this system too though. We're adding this to their messages.
There was a problem hiding this comment.
Also, when do you sleep? I'm about to finish up my work day in California. If you're working past when I do then that really puts me to shame :)
There was a problem hiding this comment.
(travelling away from home in Texas this week)
3 participants
Worker._transitionWorker.handle_stimulusandWorker.validate_state; they will remain in Worker post refactor, in methods that override those inBaseWorker.