Drop Python 3.7 #5683

jrbourbeau · 2022-01-21T18:50:27Z

This PR drops support for Python 3.7 and should be merged along with its companion PR over in dask/dask dask/dask#8572. Also see the related community conversation in dask/community#213

jakirkham · 2022-01-21T21:51:11Z

requirements.txt

 toolz >= 0.8.2
-tornado >= 5;python_version<'3.8'
-tornado >= 6.0.3;python_version>='3.8'
+tornado >= 6.0.3


This would also allow us to make the Conda package noarch again, which would help speed up building time in conda-forge

jakirkham · 2022-01-22T03:06:17Z

distributed/protocol/pickle.py

-if sys.version_info < (3, 8):
-    try:
-        import pickle5 as pickle
-    except ImportError:
-        import pickle
-else:
-    import pickle


Now that pickle protocol 5 is builtin, it should be possible to drop all of the protocol=4 lines like those that were added here ( #4019 )

Sorry @jakirkham, I missed this comment when you originally left it. I agree we probably don't need several of those protocol=4 anymore. That said, due to my bandwidth limitations I'd prefer to have those addressed in a separate PR. It would be good to have them cleaned up, but things will also work as-is on Python 3.8+

Happy to pick up as a separate PR. Looking forward to pickle protocol 5 as the default 🙂

Added draft PR ( #5826 ) with this change

jakirkham · 2022-01-22T03:07:30Z

setup.py

        "Programming Language :: Python",
-        "Programming Language :: Python :: 3.7",
        "Programming Language :: Python :: 3.8",
        "Programming Language :: Python :: 3.9",


Should we add 3.10 here or do we want to do that separately?

It requires separate effort: #5350 is still an issue

Right I guess that depends what the scope is here. In the past we have sometimes dropped and added a Python version in the same PR because of special test cases, a range of package requirements, etc. that we still wanted covered. Dropping a Python version in those cases meant we lost that test coverage, but adding a new one at the same time meant we could redistribute that workload. Not sure if that applies here yet or not. Hence the question

Should we add 3.10 here or do we want to do that separately?

I'd prefer to handle 3.10 support in a separate PR

…python-3.7

github-actions · 2022-02-02T23:49:35Z

Unit Test Results

      11 files -       1       11 suites - 1 6h 43m 49s ⏱️ - 16m 21s
  2 603 tests +      2   2 520 ✔️ +      9   79 💤 - 10 4 ❌ +3
14 342 runs - 1 216 13 344 ✔️ - 1 317 994 💤 +98 4 ❌ +3

For more details on these failures, see this check.

Results for commit f1635dd. ± Comparison against base commit 6a17957.

♻️ This comment has been updated with latest results.

jakirkham · 2022-02-03T01:19:49Z

.pre-commit-config.yaml

          # Libraries exclusively imported under `if TYPE_CHECKING:`
-          - typing_extensions  # To be reviewed after dropping Python 3.7


Should the comment also be dropped?

Good catch -- just removed that comment

jakirkham · 2022-02-03T01:21:52Z

distributed/worker.py

-from typing import TYPE_CHECKING, Any, ClassVar, Container
+from typing import TYPE_CHECKING, Any, ClassVar, Container, Literal

 if TYPE_CHECKING:
-    from typing_extensions import Literal


Is if TYPE_CHECKING: still needed here? It appears to be dropped elsewhere

The other imports are python version independent and only needed for type checking but not for runtime.

it protects what would otherwise be a circular import (which mypy deals with).

…python-3.7

crusaderky · 2022-02-16T14:20:51Z

.pre-commit-config.yaml

          - types-setuptools
          - types-psutil
-          # Libraries exclusively imported under `if TYPE_CHECKING:`
-          - typing_extensions  # To be reviewed after dropping Python 3.7


This is needed again after #5814 as it uses TypeAlias

Would it make sense to add in that PR?

yes no problem

jakirkham · 2022-02-16T19:30:23Z

Thanks James! 😄

crusaderky · 2022-02-16T21:05:13Z

FAILED distributed/tests/test_worker.py::test_fail_write_to_disk - TypeError:...
FAILED distributed/tests/test_cancelled_state.py::test_value_raises_during_spilling
FAILED distributed/tests/test_spill.py::test_spillbuffer - assert 1247 == 698

please merge from main to fix

…python-3.7

jrbourbeau · 2022-02-16T21:24:03Z

Thanks @jakirkham @crusaderky -- planning to merge this and dask/dask#8572 later today if no further comment

jakirkham · 2022-02-16T23:57:31Z

Have seen macOS queuing for quite a while. This is happening on other PRs as well. Given as this passes elsewhere and there isn't anything macOS specific here (and is really just dropping things), going to go ahead and merge. Though if issues crop up on macOS, we can revisit.

jakirkham · 2022-02-16T23:58:05Z

Thanks James for the PR and everyone for the reviews! 😄

jrbourbeau added 6 commits January 21, 2022 12:02

Remove Python 3.7 test builds

edd0d06

Update requirements

c659148

Remove Python 3.7 specific code

825cad4

Update pyupgrade and black pre-commit hooks

12b6692

Remove unneeded typing_extensions

2450141

Add readthedocs config file

5950140

jakirkham reviewed Jan 21, 2022

View reviewed changes

jakirkham reviewed Jan 22, 2022

View reviewed changes

jrbourbeau added 2 commits February 2, 2022 14:41

Merge branch 'main' of https://github.com/dask/distributed into drop-…

01d9807

…python-3.7

Update conda builds

3efb619

jakirkham reviewed Feb 3, 2022

View reviewed changes

ian-r-rose mentioned this pull request Feb 9, 2022

Avoid deadlock when two tasks are concurrently waiting for an unresolved ActorFuture #5709

Merged

4 tasks

jrbourbeau mentioned this pull request Feb 15, 2022

Drop Python 3.7 dask/dask#8572

Merged

jrbourbeau added 2 commits February 15, 2022 12:52

Merge branch 'main' of https://github.com/dask/distributed into drop-…

1e12f9b

…python-3.7

Drop Python 3.7 conda environment file

c0636b7

jrbourbeau changed the title ~~[WIP] Drop Python 3.7~~ Drop Python 3.7 Feb 15, 2022

jrbourbeau mentioned this pull request Feb 15, 2022

Drop Python 3.7 dask/community#213

Closed

Remove unnecessary comment

128f698

crusaderky reviewed Feb 16, 2022

View reviewed changes

jakirkham approved these changes Feb 16, 2022

View reviewed changes

jakirkham mentioned this pull request Feb 16, 2022

Use latest pickle #5826

Merged

3 tasks

crusaderky approved these changes Feb 16, 2022

View reviewed changes

Merge branch 'main' of https://github.com/dask/distributed into drop-…

f1635dd

…python-3.7

jakirkham merged commit 60d82c2 into dask:main Feb 16, 2022

jrbourbeau deleted the drop-python-3.7 branch February 17, 2022 01:27

This was referenced Feb 17, 2022

Drop Python 3.7 conda-forge/distributed-feedstock#198

Closed

Drop Python 3.7 conda-forge/dask-feedstock#170

Closed

		# Libraries exclusively imported under `if TYPE_CHECKING:`
		- typing_extensions # To be reviewed after dropping Python 3.7

Uh oh!

Drop Python 3.7 #5683

Drop Python 3.7 #5683

Uh oh!

Conversation

jrbourbeau commented Jan 21, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unit Test Results

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jakirkham commented Feb 16, 2022

Uh oh!

crusaderky commented Feb 16, 2022

Uh oh!

jrbourbeau commented Feb 16, 2022

Uh oh!

jakirkham commented Feb 16, 2022

Uh oh!

jakirkham commented Feb 16, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

github-actions bot commented Feb 2, 2022 •

edited

Loading