XFAIL tls explicit comm close test on py3.7 #5639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test fails with some versions of openssl. Since we're going to drop python 3.7 soon anyway, I'm just xfailing this for now.
jakirkham
reviewed
Jan 5, 2022
jakirkham
approved these changes
Jan 5, 2022
Member
jakirkham
left a comment
jakirkham
left a comment
There was a problem hiding this comment.
LGTM. Had one question above
jrbourbeau
approved these changes
Jan 5, 2022
Member
jrbourbeau
left a comment
jrbourbeau
left a comment
There was a problem hiding this comment.
Thanks @jcrist! Will merge after CI finishes up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test fails with some versions of openssl. Since we're going to drop
python 3.7 soon anyway, I'm just xfailing this for now.
Fixes #5607.