Migrate to GitHub Actions and change install script to environment files #4218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gforsyth
reviewed
Nov 16, 2020
Contributor
gforsyth
left a comment
gforsyth
left a comment
There was a problem hiding this comment.
Looks good @jacobtomlinson -- do you want to merge from master? I think those windows tests should be passing now (although I also think they should've passed after you pinned pytest-asyncio, so...)
Co-authored-by: Gil Forsyth <[email protected]>
Member
Author
|
Thanks @gforsyth. I think we may still be blocked here on some SSH tests which are failing. I think GitHub Actions causes some problem with running our mock SSH server. |
jakirkham
reviewed
Nov 30, 2020
Co-authored-by: jakirkham <[email protected]>
Member
|
Pushed a commit to fix the merge conflict. Hope that is ok 🙂 |
Member
Author
|
Thanks @jakirkham ! |
Member
|
Ofc! Do you have a sense of the current issues we are running into here? I looked at CI, but nothing obvious stuck out at me. |
jakirkham
reviewed
Dec 2, 2020
Merged
Collaborator
|
Superseded by #4504; please close |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4214
This PR migrates CI to GitHub Actions.
Changes: