Stop keep alives when worker reconnecting to the scheduler #3493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I'm not entirely sure what I've broken here. Assistance would be appreciated. |
Member
|
I'll try to take a look later today |
Member
|
If you run tests with I've pushed a patch moving the construction a bit lower, but on my machine there are still some failures. It might make sense to put this construction back in `start`` if there isn't a big reason to move it out. |
Member
Author
|
Thanks for pushing to this @mrocklin. The CI seems happy here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3488.
I don't think this fixes the problem, but I think it should address the
CommClosedErrorexceptions which are seen in the log.When a worker registers with the scheduler it starts sending keepalive messages via a periodic callback. However that never seems to stop if the connection is broken. If the connection hangs for a long period of time the worker still attempts to send the keepalive messages.
This PR moves the definitions of the
BatchedSendandkeep-alivecallback to the__init__and stops the callback during the reconnect. This is already being done for the heartbeat.