Implement ma.*_like functions #9378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Can one of the admins verify this patch? Admins can comment |
Member
|
add to allowlist |
rcomer
force-pushed
the
masked-like-funcs
branch
from
d09ee09 to
cc1a7f3
Compare
Contributor
Author
|
I forgot they would also need adding to the docs. Is it just a case of including them in https://github.com/dask/dask/blob/main/docs/source/array-api.rst? |
Contributor
Author
|
Thanks @jsignell! |
Member
|
@rcomer Hi! Thanks for working on this! We'll be highlighting this PR in a "release highlights" Twitter post. Would you be comfortable sharing your Twitter handle with me so we can tag you in it? |
Contributor
Author
|
Thanks @pavithraes! I am flyingcomer on Twitter but not very active there. (I see you have already found me!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
ones_like,zeros_likeandempty_likewithindask.array.ma. I also looked atfull_like, but that does not currently exist innumpy.ma, so I left it out for simplicity.Note that until recently (numpy/numpy#19899),
ones_likeandzeros_likewere missing fromnumpy.ma.core.__all__and therefore did not appear in thenumpy.manamespace. So I am usingnumpy.ma.coredirectly.pre-commit run --all-files