Handle dtype=None correctly in da.full#8954
Merged
jrbourbeau merged 2 commits intodask:mainfrom Apr 28, 2022
Merged
Conversation
bryanwweber
approved these changes
Apr 20, 2022
Contributor
bryanwweber
left a comment
bryanwweber
left a comment
There was a problem hiding this comment.
Thanks @tomwhite! This looks good to me. Simple enough change 😄
Member
|
Thanks, @jrbourbeau Could you please take a quick look and help merge? |
jrbourbeau
approved these changes
Apr 28, 2022
Member
jrbourbeau
left a comment
jrbourbeau
left a comment
There was a problem hiding this comment.
Thanks @tomwhite, this LGTM. I noticed there were some gpuCI failures, so I merged main to retrigger a CI run. I suspect that failure is totally unrelated to the changes here but want to make sure before merging
jrbourbeau
changed the title
dtype=None correctly in da.full
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fullinconsistency with NumPy fordtype=None#8947pre-commit run --all-files