Add missing NumPy ufuncs: abs, left_shift, right_shift, positive.#8920
Merged
Add missing NumPy ufuncs: abs, left_shift, right_shift, positive.#8920
Conversation
jcrist
reviewed
Apr 13, 2022
Member
There was a problem hiding this comment.
Thanks, can you add tests and docs for these new methods?
Tests should go in(edit - sorry, I missed that you already added the tests. nevermind!)dask/array/tests/test_ufunc.py. Most of these tests are parametrized across functions, so adding the new methods to the proper lists may be sufficient.- New methods also need to be added to the list in
docs/source/array-api.rst
Contributor
Author
|
Thanks @jcrist! Added the functions to the docs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
abs,left_shift,right_shift,positive#8915pre-commit run --all-files