absolufy-imports - No relative - PEP8 #8796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
array
dataframe
dispatch
jsignell
added
almost done
jcrist
approved these changes
Mar 10, 2022
Member
jcrist
left a comment
jcrist
left a comment
There was a problem hiding this comment.
Yay for automating away an opinion-based choice! I habitually use relative imports (they used to be the main recommendation), but habits can change.
Would like to make sure we have consensus-ish across dask + distributed before merging this though.
Collaborator
|
could you fix merge conflicts? |
crusaderky
requested changes
Mar 14, 2022
jsignell
force-pushed
the
absolufy-imports
branch
from
2326db2 to
a6d6e41
Compare
Member
Author
|
Thanks for reviewing @crusaderky! Let me know if you notice any other patterns that are wierd. |
Member
Author
|
I'm fixing conflicts then going to merge. |
jsignell
force-pushed
the
absolufy-imports
branch
from
a6d6e41 to
44092ec
Compare
Member
|
Thanks Julia! 😄 |
Member
Author
|
@dask/maintenance if you see lots of conflicts it's likely to be this 😬 |
rapids-bot bot
pushed a commit
to rapidsai/cudf
that referenced
this pull request
Mar 16, 2022
Updated imports to be compatible with latest dask after dask/dask#8796 This change is also compatible with dask versions prior to the above dask PR. Tested `import dask_cudf` with both dask `2022.02.2a220314` and `2022.02.2a220315`. Authors: - Rick Ratzel (https://github.com/rlratzel) Approvers: - Ashwin Srinath (https://github.com/shwina) URL: #10442
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matches dask/distributed#5924
Conversation in dask/distributed#5889