Add expand_dims to Dask array (#8667)#8687
Merged
Conversation
Collaborator
|
Can one of the admins verify this patch? |
Member
|
add to allowlist |
Member
|
JFYI we can almost just use the NumPy implementation of this as-is, but these coercions make that not feasible. Would add it makes sense why NumPy has those. Maybe there is a way to make NumPy's code more generalizable, but am not seeing it atm (maybe someone else does) |
jakirkham
approved these changes
Feb 11, 2022
Member
|
Thanks Tom! 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
expand_dimsto Dask array #8667pre-commit run --all-files