Fix concatenate inconsistency with NumPy for axis=None (#8668)#8686
Merged
Fix concatenate inconsistency with NumPy for axis=None (#8668)#8686
Conversation
Collaborator
|
Can one of the admins verify this patch? |
bryanwweber
approved these changes
Feb 8, 2022
Contributor
There was a problem hiding this comment.
Thanks @tomwhite! This change looks good to me, a fairly simple fix. The test failures appear to be unrelated to this change. Can you also update the docstring for da.concatenate to indicate that None is an option and will flatten all the arrays before concatenating, similar to the NumPy docstring? Thank you!
Also, I have to note the symmetry in the issue #8668 and the fixing PR #8686 😂
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
concatenateinconsistency with NumPy foraxis=None#8668pre-commit run --all-files