Add Python 3.10 support #8566
Add Python 3.10 support #8566
Conversation
github-actions
bot
added
the
needs attention
setup.cfg
Outdated
| # From https://github.com/numpy/numpy/issues/20225 | ||
| ignore:The distutils.sysconfig module is deprecated, use sysconfig instead:DeprecationWarning |
There was a problem hiding this comment.
NumPy is in the process of deprecating distutils, but that will probably take a few releases. Given as we do like to test these older releases, we should probably leave this for a while and revisit in the future
| # Not available for Python 3.9+ on conda-forge | ||
| # - bcolz |
There was a problem hiding this comment.
Depends on PR ( conda-forge/bcolz-feedstock#17 ). Looks like there are few PRs on that feedstock that are waiting. So this might be a while
Various packages have fixed issues and/or added Python 3.10 support. So refresh them based on their latest status.
|
Looks like we are seeing a flaky test failure from Outside of that we are seeing this failure in this build, which James alluded to above: _____________________________ test_local_scheduler _____________________________
[gw3] linux -- Python 3.10.2 /usr/share/miniconda3/envs/test-environment/bin/python
def test_local_scheduler():
async def f():
x = dask.delayed(inc)(1)
y = x + 1
z = await y.persist()
assert len(z.dask) == 1
> asyncio.get_event_loop().run_until_complete(f())
E DeprecationWarning: There is no current event loop
dask/tests/test_distributed.py:262: DeprecationWarning |
|
The error in |
|
Ok, with dask/distributed#5952 and the small patch I just pushed, this PR passes for me locally. Lets try to get the distributed one in soon, retest, then merge this. |
|
That's great! Thanks Jim 😄 +1 on getting this in |
| assert len(z.dask) == 1 | ||
|
|
||
| asyncio.get_event_loop().run_until_complete(f()) | ||
| asyncio.run(f()) |
There was a problem hiding this comment.
Was looking at using asyncio.run, but couldn't tell if there was something I was missing about how the event loop is setup/used here. Glad to see it is that simple 🙂
Co-authored-by: Thomas Grainger <[email protected]>
jrbourbeau
left a comment
jrbourbeau
left a comment
There was a problem hiding this comment.
Thanks all for helping finish this up! It looks like all lingering review comments have been addressed. I'll merge this tomorrow if no further comments
|
Does this mean you are back James? If so, welcome back 😄 |
jakirkham
removed
the
needs attention
|
Woo! |
Dask has Python 3.10 support with (dask#8566). Update documentation
6 participants
Still working on this but wanted to push a checkpoint up in case folks are interested
cc @jcrist, who I was chatting offline with about an
asynciochange in Python 3.10 around retrieving / creating event loopspre-commit run --all-files