Update low-level graph spec to use any hashable for keys #7163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I think it would be a good idea to emphasize in custom_collections.rst that the definition of key there is stricter than in the general case |
shwina
pushed a commit
to shwina/dask
that referenced
this pull request
Feb 5, 2021
jakirkham
pushed a commit
that referenced
this pull request
Feb 26, 2021
* Add array_safe function supporting like= kwarg * Support for like= in percentile * Add CuPy tests for percentiles * Fix array_like_safe for NumPy < 1.20 * Improve percentile perf * Generically rebuild a collection with different keys (#7142) * Add array_safe function supporting like= kwarg * Support for like= in percentile * Add CuPy tests for percentiles * Fix array_like_safe for NumPy < 1.20 * Improve percentile perf * Remove note comparing np/merge_sorted * Update low-level graph spec to use any hashable for keys (#7163) * Remove unused merge_sorted Co-authored-by: Peter Andreas Entschev <[email protected]> Co-authored-by: Ashwin Srinath <[email protected]> Co-authored-by: crusaderky <[email protected]> Co-authored-by: James Bourbeau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref https://github.com/dask/dask/pull/7142/files#r569620160
cc @eriknw @crusaderky