Fixup da.asarray and da.asanyarray for datetime64 dtype and xarray objects #5334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…jects. `da.asanyarray()` current crashes if passed a datetime64 dtype array, as noted in pydata/xarray#3220: > elif hasattr(a, "data") and type(a).__module__.startswith("xarray."): E ValueError: cannot include dtype 'M' in a buffer Reversing the order of these checks fixes the issue. I also adjusted `da.asarray()` to coerce xarray objects in the same way as `da.asanyarray()`.
mrocklin
reviewed
Aug 28, 2019
Member
|
Looks good to me. There might be a small typo (I think). Suggestion above. |
Co-Authored-By: Matthew Rocklin <[email protected]>
Member
Author
|
@mrocklin Thanks for catching my error! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
da.asanyarray()currently crashes if passed a datetime64 dtype array, as notedin pydata/xarray#3220:
Reversing the order of these checks fixes the issue. (
.datais an attribute of NumPy arrays that creates a buffer, which isn't valid for datetime dtypes.)I also adjusted
da.asarray()to coerce xarray objects in the same way asda.asanyarray().black dask/flake8 dask