Skip to content

Raise ValueError if stack is given no arrays #4975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jrbourbeau merged 1 commit into from
Jun 21, 2019
Merged

Raise ValueError if stack is given no arrays #4975

jrbourbeau merged 1 commit into from
Jun 21, 2019

Conversation

@jakirkham
Copy link
Member

@jakirkham jakirkham commented Jun 20, 2019 •
edited
Loading

Analog to PR ( #4927 ) except for da.stack.

  • Tests added / passed
  • Passes flake8 dask

@jakirkham jakirkham mentioned this pull request Jun 20, 2019
Merged
2 tasks
@jakirkham
Copy link
Member Author

jakirkham commented Jun 20, 2019

Planning on merging tomorrow if no comments.

jrbourbeau
jrbourbeau approved these changes Jun 21, 2019
View reviewed changes
Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is in, thanks @jakirkham!

@jrbourbeau jrbourbeau merged commit bf7e446 into dask:master Jun 21, 2019
@jakirkham jakirkham deleted the err_if_no_arrs_stack branch June 21, 2019 00:14
@jakirkham
Copy link
Member Author

jakirkham commented Jun 21, 2019

Thanks James! 😄

@jakirkham jakirkham mentioned this pull request Jun 21, 2019
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jrbourbeau jrbourbeau jrbourbeau approved these changes

Assignees

No one assigned

Labels

array

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jakirkham @jrbourbeau