Refresh Distributed test for HDFS#3609
Merged
Merged
Conversation
2 tasks
jakirkham
force-pushed
the
refresh_bytes_distributed_test
branch
from
June 13, 2018 19:07
3774e85 to
59894f1
Compare
mrocklin
reviewed
Jun 13, 2018
|
|
||
|
|
||
| @pytest.mark.skipif(not distributed) | ||
| def test_distributed(hdfs): |
Member
There was a problem hiding this comment.
Thanks for doing this.
I believe that this will also need the loop pytest fixture.
Member
Author
There was a problem hiding this comment.
Ah, thanks for this. Didn't realize loop was a bit more magical. Do we need anything for the other functions here?
jakirkham
force-pushed
the
refresh_bytes_distributed_test
branch
from
June 13, 2018 19:27
59894f1 to
2d988b5
Compare
Member
|
I don't think so. `loop` is only necessary when using tornado (which is
started by dask.distributed). I think that this is the only test where
it's relevant.
Also, in hopes of nerd sniping you, it would be nice to make all of this
more pleasant with pytest fixtures:
dask/distributed#1966
Just in case you're interested :)
…On Wed, Jun 13, 2018 at 3:24 PM, jakirkham ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In dask/bytes/tests/test_hdfs.py
<#3609 (comment)>:
> @@ -297,8 +305,8 @@ def test_glob(hdfs):
{basedir + p for p in ['/a', '/a1', '/a2', '/a3', '/b1', '/c', '/c2']})
***@***.***(not distributed)
def test_distributed(hdfs):
Ah, thanks for this. Didn't realize loop was a bit more magical. Do we
need anything for the other functions here?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3609 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AASszKWNBQHbPHSXMkKUivPrm3QeiYWVks5t8Wb9gaJpZM4Umwxh>
.
|
jakirkham
force-pushed
the
refresh_bytes_distributed_test
branch
2 times, most recently
from
June 13, 2018 21:11
568a293 to
ba41a73
Compare
Member
Author
|
So flake8 doesn't seem to like the use of the |
jakirkham
commented
Jun 14, 2018
|
|
||
| def test_distributed(hdfs): | ||
| dist = pytest.importorskip('distributed') | ||
| @pytest.mark.skipif(not distributed) |
Member
Author
There was a problem hiding this comment.
Seems the issue is flake8 wants to complain about this line. Though this falls out of the function having the loop variable and a decorator.
Updates the testing style for HDFS using a Distributed Client. This makes it more consistent with similar tests using the Distributed Client elsewhere.
jakirkham
force-pushed
the
refresh_bytes_distributed_test
branch
from
June 14, 2018 05:03
e1e089d to
e116b17
Compare
Member
|
Thanks @jakirkham |
2 tasks
Member
Author
|
Thanks. Appears |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on this comment.
Updates the testing style for HDFS using a Distributed Client. This makes it more consistent with similar tests using the Distributed Client elsewhere.
cc @mrocklin
flake8 dask