Repository navigation
Generalize vindex in dask.array - #2573
Merged
Merged
Conversation
Extends dask.array.Array.vindex[] so it can handle multi-dimensional indexes (using broadcasting like numpy) and non-full slices. This will be useful for vectorized indexing in xarray (PR 1473).
Member
|
It looks like installation on travis-ci has started to fail. This is likely unrelated to this PR |
Member
|
The travis-ci hiccup seems to have mysteriously disappeared. |
Member
It was an issue with anaconda.org, leading to packages from conda-forge not being picked up. |
Member
|
This seems fine to me. Merging soon if there are no further comments. |
Member
Author
|
Sounds like I can go ahead and merge this? |
Member
|
Sorry for the delay @shoyer . Thank you for persisting. |
Member
Author
|
I'm just excited that we'll be able to use it to support some really sweet
vectorized indexing methods in the next release of xarray :).
…On Fri, Aug 4, 2017 at 5:33 PM, Matthew Rocklin ***@***.***> wrote:
Sorry for the delay @shoyer <https://github.com/shoyer> . Thank you for
persisting.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2573 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABKS1sCepz5ffuEJvpuG3mYlHoF-hBRyks5sU7hOgaJpZM4OpRiv>
.
|
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends dask.array.Array.vindex[] so it can handle multi-dimensional indexes, broadcasting like numpy and non-full slices.
This will be useful for vectorized indexing in xarray (pydata/xarray#1473) and allows using helper functions like
np.ix_().