compress: Partially handle condition as Dask array#2545
Merged
mrocklin merged 1 commit intodask:masterfrom Jul 25, 2017
Merged
Conversation
To prep for making `compress` a lazy function, handle the `condition` array argument as a Dask Array as long as possible. Unfortunately it still needs to be converted to a NumPy Array to create the needed slice to apply to the input array `a`. However this little rewrite should make it easier to focus on just getting that portion of code into Dask Arrays instead of NumPy Arrays.
This was referenced Jul 24, 2017
Closed
Member
Author
|
Is this also ok @mrocklin? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Works towards resolving issue ( #2540 ).
To prep for making
compressa lazy function, handle theconditionarray argument as a Dask Array as long as possible. Unfortunately it still needs to be converted to a NumPy Array to create the needed slice to apply to the input arraya. However this little rewrite should make it easier to focus on just getting that portion of code into Dask Arrays instead of NumPy Arrays.