Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this is an important first step towards making the Expr classes more traditional classes. The concept with _parameters, etc. has been causing issues in the past in the context of inheritance (not to mention the confusion around recursion errors and other things)
This change also further highlights a couple of anti patterns where some implementations set attributes on the classes without them being registered as parameters which poses challenges to serialization and tokenization
This needs #11835 since otherwise I cannot properly subclass
Exprfor the test