-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
concatenate inconsistency with NumPy for axis=None #8668
Copy link
Copy link
Closed
Labels
Description
What happened:
Calling concatenate with axis=None gives an error rather than flattening the inputs, which is what happens in NumPy.
What you expected to happen:
Behaviour the same as NumPy.
Minimal Complete Verifiable Example:
>>> import numpy as np
>>> np.concatenate([np.array([1, 2]), np.array([[3, 4], [5, 6]])], axis=None)
array([1, 2, 3, 4, 5, 6])
>>> import dask.array as da
>>> da.concatenate([da.array([1, 2]), da.array([[3, 4], [5, 6]])], axis=None)
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/Users/tom/projects-workspace/dask/dask/array/core.py", line 4050, in concatenate
if axis < 0:
TypeError: '<' not supported between instances of 'NoneType' and 'int'Anything else we need to know?:
This fix is needed for the Array API (dask/community#109), where the function is called concat.
Environment:
- Dask version: main
- Python version: 3.8
- Operating System: Mac
- Install method (conda, pip, source): source
Reactions are currently unavailable