Skip to content

Conversation

@knst
Copy link
Collaborator

@knst knst commented Jul 25, 2023

During implementation MN EHF several improvements came up for DIP-0023.

  • renamed version to versionBit in MnEhf Signal to avoid confusion. version inside signal doesn't mean a version of message. It means "number of version bit" for chain params (BIP9). This one is the most important changes from these 3.
  • for Tx "Mn EHF" unlikely we will have more than 255 version ever. That's very minor improvement because this type of transaction is rare, but I see no good reason to have 2 bytes for version.
  • size of "MnEHF signal" is known and it is exactly 129 bytes. The length is not "various" depending on content. Fixed this one in DIP too.

Copy link
Contributor

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@thephez
Copy link
Collaborator

thephez commented Jul 25, 2023

@knst Can you add a PR description about this change? It's not entirely obvious to me why this change was necessary.

@thephez thephez merged commit eb98c64 into dashpay:master Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants