Yet another fix for rpc autoCompleter #844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UdjinM6
changed the title
UdjinM6
changed the title
|
ACK af3e36f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#752 was not enough, edit field wasn't cleared sometimes
How to reproduce the issue in current build: open Console, close it, open it again, start writing some rpc command and try to pick it from the list using arrow keys, hit Enter. Now edit field is not being cleared as it should be, works on second try only (i.e. same as before).
Using event filter to forward messages from autoCompleter popup to lineEdit instead of using
connectmethod solves the issue.EDIT: hold on, there is smth more
EDIT2: done, should be working now :)
EDIT3: works for me on mac, pls test on windows and linux