config - changed network bip32 values, testnet/regtest pubkey #767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mainnet bip32 seeds start with dpub/dprv testnet/regtest bip32 seeds start with DPUB/DPRV only create public testnet/regtest addresses starting with y
|
Looks good! 👍 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated testnet (and regtest) address constant to only create addresses beginning with 'y' for less potential for confusion with mainnet addresses beginning with 'X'. Previous value would create values of 'x' and 'y'.
Updated bip32 constants to remove 'drk' reference and still differentiate from bitcoin bip32 seeds. Public/private seeds will be prefixed with dpub/dprv for mainnet and DPUB/DPRV for testnet/regtest. Values chosen per developer discussions here: https://www.dash.org/forum/threads/dash-bip32-serialization-values-dev-discussion-wont-apply-to-most.8092 .