Skip to content

Cleanup GetBlockValue and GetMasternodePayment #730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
poiuty wants to merge 1 commit into from
Closed

Cleanup GetBlockValue and GetMasternodePayment #730

poiuty wants to merge 1 commit into from

Conversation

@poiuty
Copy link

@poiuty poiuty commented Mar 8, 2016

Now we have ASIC and dynamic reward will soon stop working. So, let's simplify code and cleanup it.
Also I think we are no longer needed if else and separation of main or test net.

@UdjinM6
Copy link

UdjinM6 commented Mar 8, 2016

nACK

  1. I have no crystal ball to say that diff will only rise.
  2. even if we accept this theory and decide to change block reward to some constant value one day making changes this way is absolutely unacceptable because this will break validation for historical blocks.

@schinzelh
Copy link

schinzelh commented Mar 8, 2016

NACK as well:

  • this breaks validation of historic blocks and
  • is actually a hard fork

So I neither agree on the concept nor on its implementation.

@UdjinM6 UdjinM6 closed this Mar 8, 2016
@poiuty poiuty deleted the patch-1 branch March 8, 2016 20:44
@schinzelh schinzelh mentioned this pull request Jun 11, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@poiuty @UdjinM6 @schinzelh