Reviewing files that changed from the base of the PR and between 123ee5e and 72d2868.

• src/Makefile.qt.include (2 hunks)
• src/qt/addressbookpage.cpp (1 hunks)
• src/qt/addresstablemodel.cpp (1 hunks)
• src/qt/appearancewidget.cpp (5 hunks)
• src/qt/appearancewidget.h (2 hunks)
• src/qt/askpassphrasedialog.cpp (1 hunks)
• src/qt/bitcoin.cpp (3 hunks)
• src/qt/bitcoingui.cpp (1 hunks)
• src/qt/coincontroldialog.cpp (1 hunks)
• src/qt/governancelist.cpp (1 hunks)
• src/qt/guiutil.cpp (0 hunks)
• src/qt/guiutil.h (0 hunks)
• src/qt/guiutil_font.cpp (1 hunks)
• src/qt/guiutil_font.h (1 hunks)
• src/qt/masternodelist.cpp (1 hunks)
• src/qt/modaloverlay.cpp (1 hunks)
• src/qt/openuridialog.cpp (1 hunks)
• src/qt/optionsmodel.cpp (4 hunks)
• src/qt/overviewpage.cpp (3 hunks)
• src/qt/proposalwizard.cpp (1 hunks)
• src/qt/qrdialog.cpp (1 hunks)
• src/qt/qrimagewidget.cpp (1 hunks)
• src/qt/receivecoinsdialog.cpp (1 hunks)
• src/qt/receiverequestdialog.cpp (1 hunks)
• src/qt/rpcconsole.cpp (1 hunks)
• src/qt/sendcoinsdialog.cpp (1 hunks)
• src/qt/sendcoinsentry.cpp (1 hunks)
• src/qt/signverifymessagedialog.cpp (1 hunks)
• src/qt/splashscreen.cpp (1 hunks)
• src/qt/test/apptests.cpp (1 hunks)
• src/qt/trafficgraphwidget.cpp (1 hunks)
• src/qt/transactiondescdialog.cpp (1 hunks)
• src/qt/utilitydialog.cpp (1 hunks)
• src/qt/walletview.cpp (1 hunks)
• test/util/data/non-backported.txt (1 hunks)

• src/qt/guiutil.h
• src/qt/guiutil.cpp

src/qt/proposalwizard.cpp (1)

16-16: LGTM!

The include for guiutil_font.h is correctly added and necessary since this file uses GUIUtil::setFont and GUIUtil::updateFonts which are now declared in the new font utilities header.

src/qt/appearancewidget.h (1)

51-55: Verify member initialization in constructor.

These members are now declared without in-class initializers. The type of prevFontFamily changed from GUIUtil::FontFamily (enum) to QString, which aligns with the new FontRegistry-based approach where fonts are identified by name strings.

Ensure the constructor in appearancewidget.cpp properly initializes all five members (prevTheme, prevScale, prevFontFamily, prevWeightNormal, prevWeightBold) to avoid undefined behavior from reading uninitialized values.

src/Makefile.qt.include (1)

142-142: LGTM!

Build integration is correct:

• qt/guiutil_font.h is properly added to BITCOIN_QT_H for the header
• qt/guiutil_font.cpp is properly added to BITCOIN_QT_BASE_CPP for the source

Based on learnings, new non-backported files should also be added to test/util/data/non-backported.txt. The AI summary indicates this has been done, but please verify that src/qt/guiutil_font.* entries are present in that file.

Also applies to: 234-234

src/qt/trafficgraphwidget.cpp (1)

9-9: LGTM!

The include is correctly added since this file uses GUIUtil::getFont at lines 171-172, which is now declared in the new font utilities header.

src/qt/sendcoinsdialog.cpp (1)

18-18: LGTM!

The include is correctly added since this file uses GUIUtil::setFont and GUIUtil::updateFonts, which are now declared in the new font utilities header.

src/qt/bitcoingui.cpp (1)

13-13: LGTM!

The include is correctly added since this file extensively uses font utilities (GUIUtil::setFont, GUIUtil::updateFonts, GUIUtil::getFontNormal), which are now declared in the new font utilities header.

src/qt/modaloverlay.cpp (1)

10-10: LGTM!

The include is correctly added since this file uses GUIUtil::setFont and GUIUtil::updateFonts, which are now declared in the new font utilities header.

src/qt/test/apptests.cpp (1)

11-11: LGTM - Include supports font infrastructure refactoring.

The addition of guiutil_font.h aligns with the PR's objective to extract font utilities into dedicated headers. The include is necessary for the GUIUtil::loadFonts() call at line 82.

src/qt/receiverequestdialog.cpp (1)

10-10: LGTM - Include supports font infrastructure refactoring.

The addition of guiutil_font.h is necessary for the GUIUtil::updateFonts() call at line 29 and aligns with the PR's font infrastructure extraction.

src/qt/askpassphrasedialog.cpp (1)

15-15: LGTM - Include supports font infrastructure refactoring.

The addition of guiutil_font.h is necessary for the font utility calls at lines 34 and 36 (GUIUtil::setFont() and GUIUtil::updateFonts()), supporting the PR's objective to extract font utilities.

src/qt/coincontroldialog.cpp (1)

16-16: LGTM - Include supports font infrastructure refactoring.

The addition of guiutil_font.h is necessary for the font utility calls at lines 55-61 and 63, supporting the PR's font infrastructure extraction objective.

src/qt/governancelist.cpp (1)

21-21: LGTM - Include supports font infrastructure refactoring.

The addition of guiutil_font.h is necessary for the font utility calls at lines 315-317 and 356, aligning with the PR's objective to extract font utilities into dedicated headers.

src/qt/transactiondescdialog.cpp (1)

9-9: LGTM - Include supports font infrastructure refactoring.

The addition of guiutil_font.h is necessary for the GUIUtil::updateFonts() call at line 20 and aligns with the PR's font infrastructure extraction.

src/qt/masternodelist.cpp (1)

8-8: LGTM - Includes support font refactoring and coin utilities.

The additions are necessary:

• coins.h at line 8 is required for the Coin type used at line 182
• guiutil_font.h at line 12 is necessary for the font utility calls at lines 43-46 and 94

Both includes align with the PR's font infrastructure extraction objective.

Also applies to: 12-12

src/qt/qrimagewidget.cpp (1)

8-8: LGTM - Include supports font infrastructure refactoring.

The addition of guiutil_font.h is necessary for the GUIUtil::getFontNormal() call at line 86 and aligns with the PR's objective to extract font utilities into dedicated headers.

src/qt/sendcoinsentry.cpp (1)

16-16: LGTM!

The include is correctly placed after guiutil.h and is necessary for the GUIUtil::setFont() and GUIUtil::updateFonts() calls used in this file's constructor.

src/qt/rpcconsole.cpp (1)

21-21: LGTM!

The include is correctly placed and necessary. This file makes extensive use of font utilities including GUIUtil::setFont(), GUIUtil::updateFonts(), and GUIUtil::fixedPitchFont() for console rendering and UI styling.

src/qt/qrdialog.cpp (1)

11-11: LGTM!

The include is correctly placed after guiutil.h and is necessary for the GUIUtil::setFont() and GUIUtil::updateFonts() calls in the constructor.

src/qt/addresstablemodel.cpp (1)

9-9: LGTM!

The include is correctly placed after guiutil.h and is necessary for the GUIUtil::getFontNormal() call used in the data() method when returning the font for the Address column.

test/util/data/non-backported.txt (1)

30-30: LGTM!

The new font utility files are correctly added to the non-backported list in alphabetical order. Based on learnings, new files not from Bitcoin backports must be added here, and this glob pattern appropriately covers the C++ source and header files (guiutil_font.cpp and guiutil_font.h).

src/qt/splashscreen.cpp (1)

19-19: LGTM! Include addition is necessary for the font refactoring.

The include is required since this file uses GUIUtil::getFontNormal() and GUIUtil::getFontBold() (lines 61-62, 233), which are now part of the extracted font infrastructure.

src/qt/addressbookpage.cpp (1)

17-17: LGTM! Include addition is necessary for the font refactoring.

The include is required since this file calls GUIUtil::updateFonts() (line 124), which is now part of the extracted font infrastructure.

src/qt/utilitydialog.cpp (1)

15-15: LGTM! Include addition is necessary for the font refactoring.

The include is required since this file calls GUIUtil::updateFonts() (lines 40, 195), which is now part of the extracted font infrastructure.

src/qt/signverifymessagedialog.cpp (1)

11-11: LGTM! Include addition is necessary for the font refactoring.

The include is required since this file uses GUIUtil::setFont() and GUIUtil::updateFonts() (lines 57-59, 61, 115-117), which are now part of the extracted font infrastructure.

src/qt/openuridialog.cpp (1)

10-10: LGTM! Include addition is necessary for the font refactoring.

The include is required since this file calls GUIUtil::updateFonts() (line 23), which is now part of the extracted font infrastructure.

src/qt/walletview.cpp (1)

14-14: LGTM! Include addition is necessary for the font refactoring.

The include is required since this file uses GUIUtil::setFont() and GUIUtil::updateFonts() (lines 71-74), which are now part of the extracted font infrastructure.

src/qt/receivecoinsdialog.cpp (1)

10-10: LGTM! Include addition is necessary for the font refactoring.

The include is required since this file uses GUIUtil::setFont() and GUIUtil::updateFonts() (lines 26-30), which are now part of the extracted font infrastructure.

src/qt/overviewpage.cpp (2)

12-12: LGTM! Include addition is necessary for the font refactoring.

The include is required since this file uses multiple font APIs including GUIUtil::setFont(), GUIUtil::updateFonts(), and the new g_font_registry.GetScaledFontSize().

---

74-74: Migration to FontRegistry API is complete and correctly initialized.

Verification confirms:

• No remaining calls to the old GUIUtil::getScaledFontSize() API exist in the codebase
• g_font_registry is a global variable initialized at startup and configured early in bitcoin.cpp (before any UI painting occurs)
• Both lines 74 and 95 correctly use the new GUIUtil::g_font_registry.GetScaledFontSize() API

The code is ready.

src/qt/optionsmodel.cpp (2)

15-15: LGTM! Clean migration to FontRegistry.

The refactoring systematically replaces direct font handling with FontRegistry-based methods. The addition of the explicit updateFonts() call at lines 157-159 ensures fonts are properly applied after all font-related settings are loaded during initialization. The fallback logic at lines 127-132 and 144-151 correctly handles unsupported weights by selecting appropriate defaults.

Also applies to: 101-159

---

557-572: Well-structured weight-to-index conversion with proper fallbacks.

The read logic correctly attempts to convert stored weights to indices and falls back to registry defaults when the stored weight is unavailable (index == -1). The assertions ensure the fallback values are always valid.

src/qt/appearancewidget.cpp (2)

23-28: Well-implemented state preservation and restoration.

The constructor captures initial font state from the registry (lines 23-28), and the destructor correctly restores it when changes aren't accepted (lines 67-80). This ensures a proper cancel/revert experience. The explicit updateFonts() call at line 80 applies the restored state.

Also applies to: 67-80

---

36-38: Good: Dynamic font family population.

Populating the font family combo from g_fonts_known makes the UI automatically reflect available fonts without hard-coding font names.

src/qt/bitcoin.cpp (2)

489-492: LGTM! CLI arguments properly reference FontRegistry constants.

The argument setup at lines 489-492 correctly uses g_fonts_known, FontRegistry::DEFAULT_FONT, DEFAULT_FONT_SCALE, and weightToArg() to derive default values and valid ranges. This ensures CLI help text stays synchronized with the actual font subsystem.

---

673-709: Comprehensive font validation and application.

The validation blocks properly check CLI arguments, convert them via the registry, and display error dialogs for invalid inputs. The final updateFonts() call at lines 708-709 ensures all font changes are applied consistently.

src/qt/guiutil_font.cpp (4)

184-247: LGTM! Robust font loading with proper error handling.

The loadFonts() function correctly:

• Preserves the system default font before loading custom fonts (line 187)
• Loads all Montserrat variants including italic styles (lines 195-206)
• Returns false and clears osDefaultFont if any font fails to load (lines 209-212)
• Registers all known fonts with the registry (lines 240-242)

---

297-403: Well-structured font update logic with proper cleanup.

The updateFonts() function demonstrates good engineering:

• Lines 309-329: Cleans up null QPointers from deleted widgets to prevent use-after-free
• Lines 381-386: Defers font application to a separate loop to avoid font inheritance issues (as noted in the comment)
• Lines 388-402: Updates global class fonts for UI components not in the widget tree

The assertion at line 350 is appropriate for debug builds to catch font initialization issues.

---

405-479: LGTM! Platform-specific font handling is appropriate.

The getFont() overloads provide flexible APIs for font construction. The platform-specific Montserrat handling at lines 414-433 correctly:

• Uses setStyleName() on macOS to select font variants (lines 416-426)
• Uses family name suffixes on other platforms (lines 428-432)

This accounts for Qt font handling differences across platforms.

---

127-182: Clever weight detection via text width comparison.

The weight calculation logic is well-designed:

• CalcSupportedWeights() (lines 127-151) detects which font weights actually render differently by comparing text widths—this is a practical solution to Qt's limited font introspection
• CalcDefaultWeights() (lines 169-182) ensures normal and bold weights are distinct, falling back to the next heavier weight if they would otherwise be identical

Reviewing files that changed from the base of the PR and between 72d2868 and 719717a.

• src/qt/guiutil_font.h (1 hunks)

src/qt/guiutil_font.h (2)

23-38: LGTM: Well-designed FontInfo struct.

The explicit constructor and deleted default constructor ensure proper initialization, and the structure cleanly encapsulates font weight information.

---

1-1: Run clang-format to fix formatting issues.

The pipeline failure indicates that this file has clang-format differences. Please run clang-format on this file to resolve the CI check failure.

#!/bin/bash
# Run clang-format on the file
clang-format -i src/qt/guiutil_font.h

⛔ Skipped due to learnings

Learnt from: kwvg
Repo: dashpay/dash PR: 6529
File: src/rpc/governance.cpp:1074-1089
Timestamp: 2025-02-14T15:15:58.165Z
Learning: Code blocks marked with `// clang-format off` and `// clang-format on` directives should be excluded from clang-format suggestions as they are intentionally formatted manually for better readability.

Learnt from: kwvg
Repo: dashpay/dash PR: 6729
File: src/rpc/evo.cpp:1273-1273
Timestamp: 2025-07-09T15:05:36.250Z
Learning: When clang-format suggestions significantly harm readability (like splitting logical parameter groups across multiple lines), it's acceptable to use `// clang-format off` and `// clang-format on` directives to exclude the problematic section from automatic formatting, prioritizing code readability over strict line length compliance.

Learnt from: CR
Repo: dashpay/dash PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-24T16:41:22.457Z
Learning: Dash extends Bitcoin Core through composition with minimal changes to the Bitcoin Core foundation

Learnt from: kwvg
Repo: dashpay/dash PR: 6761
File: src/chainlock/signing.h:5-6
Timestamp: 2025-07-23T09:30:34.631Z
Learning: Dash Core uses BITCOIN_ prefix for header guards as the standard convention, inherited from Bitcoin Core. Only a few BLS-specific files in src/bls/ use DASH_ prefix. The vast majority of files (385+) use BITCOIN_ prefix.

Reviewing files that changed from the base of the PR and between 719717a and 2dc48de.

• src/qt/appearancewidget.cpp
• src/qt/appearancewidget.h
• src/qt/bitcoin.cpp
• src/qt/guiutil_font.cpp
• src/qt/guiutil_font.h
• src/qt/optionsmodel.cpp
• src/qt/overviewpage.cpp
• src/qt/test/apptests.cpp

• src/qt/overviewpage.cpp
• src/qt/appearancewidget.h
• src/qt/bitcoin.cpp

• GitHub Check: predict_conflicts
• GitHub Check: win64-build / Build source
• GitHub Check: mac-build / Build source
• GitHub Check: linux64_nowallet-build / Build source
• GitHub Check: linux64_tsan-build / Build source
• GitHub Check: linux64_sqlite-build / Build source
• GitHub Check: linux64_ubsan-build / Build source
• GitHub Check: linux64-build / Build source
• GitHub Check: linux64_fuzz-build / Build source
• GitHub Check: arm-linux-build / Build source
• GitHub Check: Lint / Run linters

src/qt/test/apptests.cpp (1)

82-84: LGTM! Correct initialization order for font setup.

The call to setApplicationFont() is correctly placed after loadFonts() and before createOptionsModel(), ensuring fonts are properly initialized before the options model processes font-related settings.

src/qt/optionsmodel.cpp (3)

156-158: Good: Batched font update after all settings.

Calling updateFonts() once after processing all font-related settings (family, scale, weight normal, weight bold) is efficient and prevents multiple redundant font updates.

---

100-108: LGTM! Font family initialization with proper flow.

The initialization correctly:

1. Sets a default value using FontRegistry::DEFAULT_FONT
2. Registers the font before setting it
3. Calls setApplicationFont() to apply changes
4. Handles command-line override gracefully

---

553-568: The assertion on lines 558/566 is safe and will not fail. The default weights are guaranteed to be in the supported weights list.

In CalcDefaultWeights (guiutil_font.cpp:189-200), m_normal_default and m_bold_default are set exclusively by calling GetBestMatch, which always returns a weight from m_supported_weights (lines 173-187). Since CalcSupportedWeights ensures m_supported_weights is never empty (line 169 provides a fallback), and both defaults are sourced from this non-empty list, WeightToIdx(GetWeightNormalDefault()) will always find the weight and return a valid index. The assertion is correct.

src/qt/appearancewidget.cpp (1)

36-38: LGTM! Dynamic font family population.

The font family combo box is now populated from g_fonts_known, which allows for extensibility if additional fonts are registered at runtime.

src/qt/guiutil_font.cpp (2)

69-74: Nice helper function for debug logging.

The qstrprintf template provides a clean wrapper around tinyformat for Qt string output, improving code readability compared to manual conversions.

---

204-261: Robust font loading with proper error handling.

The loadFonts() function correctly:

1. Stores the OS default font before any modifications
2. Loads all Montserrat variants including italic styles
3. Checks for failures and cleans up osDefaultFont on error
4. Registers all known fonts after successful loading

src/qt/guiutil_font.h (2)

45-58: Well-designed constants with platform-specific handling.

The FontRegistry class provides clear constants for defaults with appropriate platform-specific handling for macOS font weights. The use of constexpr ensures compile-time evaluation.

---

8-16: LGTM! Clean header organization.

The includes are properly organized with Qt headers first, followed by standard library headers. The <map> header is now included as addressed in a previous review.

Reviewing files that changed from the base of the PR and between 2dc48de and 14137c6.

• src/qt/askpassphrasedialog.cpp
• src/qt/bitcoin.cpp
• src/qt/bitcoingui.cpp
• src/qt/coincontroldialog.cpp
• src/qt/governancelist.cpp
• src/qt/guiutil.cpp
• src/qt/guiutil_font.cpp
• src/qt/guiutil_font.h
• src/qt/masternodelist.cpp
• src/qt/modaloverlay.cpp
• src/qt/optionsdialog.cpp
• src/qt/optionsmodel.cpp
• src/qt/overviewpage.cpp
• src/qt/proposalwizard.cpp
• src/qt/qrdialog.cpp
• src/qt/receivecoinsdialog.cpp
• src/qt/rpcconsole.cpp
• src/qt/sendcoinsdialog.cpp
• src/qt/sendcoinsentry.cpp
• src/qt/signverifymessagedialog.cpp
• src/qt/test/apptests.cpp
• src/qt/trafficgraphwidget.cpp
• src/qt/walletview.cpp

• src/qt/coincontroldialog.cpp
• src/qt/walletview.cpp
• src/qt/overviewpage.cpp
• src/qt/rpcconsole.cpp

• GitHub Check: win64-build / Build source
• GitHub Check: linux64_tsan-build / Build source
• GitHub Check: linux64_ubsan-build / Build source
• GitHub Check: linux64-build / Build source
• GitHub Check: linux64_fuzz-build / Build source
• GitHub Check: linux64_sqlite-build / Build source
• GitHub Check: arm-linux-build / Build source
• GitHub Check: mac-build / Build source
• GitHub Check: linux64_nowallet-build / Build source
• GitHub Check: Lint / Run linters

src/qt/askpassphrasedialog.cpp (1)

15-15: LGTM! Font registry migration is correct.

The changes properly migrate from the old FontWeight enum to the new FontRegistry-based approach, following the pattern used throughout the codebase.

Also applies to: 34-34

src/qt/bitcoin.cpp (2)

489-492: LGTM! CLI argument setup correctly references FontRegistry defaults.

The help text for font-related arguments properly displays the available fonts and default values from the FontRegistry. The use of Join(GUIUtil::g_fonts_known, ", ") ensures the help text stays in sync with supported fonts.

---

664-711: Font initialization and validation logic is well-structured.

The font loading and validation sequence is correct:

1. Load fonts with error handling (lines 664-667)
2. Validate and set font family with registry checks (lines 671-677)
3. Validate and set normal/bold weights (lines 679-697)
4. Validate and set font scale (lines 699-708)
5. Apply fonts via updateFonts() and setApplicationFont() (lines 710-711)

The error messages are clear and user-friendly. Based on past review comments, the crash issue with invalid fonts has been resolved with proper error handling and arbitrary font support.

src/qt/guiutil_font.cpp (1)

1-535: LGTM! Comprehensive font subsystem implementation.

The new font module successfully encapsulates font management with:

• Proper resource management using smart pointers
• FontInfo class for per-font weight calculation
• FontRegistry class for centralized font state
• Lifecycle-aware widget tracking with QPointer
• Platform-specific handling (macOS weight/style naming)
• Robust font loading with validation

The implementation follows Qt 5 patterns and integrates well with the existing codebase.

Based on learnings, clang-format issues will be handled manually per developer preference in refactoring PRs.

src/qt/guiutil.cpp (1)

300-301: LGTM! Appearance setup correctly migrated to font registry.

The font weight specifications for heading and subheading properly use the registry-derived weights, maintaining the visual hierarchy while enabling dynamic font customization.

src/qt/qrdialog.cpp (1)

11-11: LGTM! Consistent font registry migration.

The QR dialog properly adopts the font registry pattern for its title label.

Also applies to: 24-24

src/qt/test/apptests.cpp (1)

11-11: LGTM! Test environment properly initializes fonts.

The addition of setApplicationFont() after loadFonts() ensures the test environment has properly configured fonts, matching the initialization sequence in the main application.

Also applies to: 83-83

src/qt/modaloverlay.cpp (1)

10-10: LGTM! Modal overlay font styling migrated correctly.

The multiple label widgets are properly styled with the registry-derived bold weight.

Also applies to: 32-32

src/qt/trafficgraphwidget.cpp (1)

9-9: LGTM! Traffic graph statistics fonts properly configured.

The font creation for the traffic statistics panel correctly uses the registry-derived weights with explicit sizes, maintaining the visual hierarchy between title and data labels.

Also applies to: 171-172

src/qt/sendcoinsentry.cpp (1)

16-42: Font registry integration in SendCoinsEntry looks correct

New qt/guiutil_font.h include and use of GUIUtil::g_font_registry.GetWeightNormal() in the setFont call are consistent with the new font subsystem; GUIUtil::updateFonts() is invoked once afterward, so behavior should be preserved.

src/qt/proposalwizard.cpp (1)

16-50: Header font change uses registry correctly

Including qt/guiutil_font.h and switching labelHeader to {GUIUtil::g_font_registry.GetWeightBold(), 16} aligns with the centralized font registry and keeps existing behavior.

src/qt/bitcoingui.cpp (1)

13-19: Toolbar/tab font use of FontRegistry is consistent

The added qt/guiutil_font.h include and use of GUIUtil::g_font_registry.GetWeightNormal()/GetWeightBold() for toolbar tab buttons and highlightTabButton are type‑correct and keep the prior visual semantics.

Also applies to: 757-770, 1239-1243

src/qt/receivecoinsdialog.cpp (1)

10-31: Receive dialog label fonts wired into registry correctly

The new qt/guiutil_font.h include and the two GUIUtil::setFont calls using g_font_registry (bold header + normal body labels) are straightforward and consistent with the new font infrastructure; GUIUtil::updateFonts() is called once after.

src/qt/masternodelist.cpp (1)

8-15: Includes and font registry usage in MasternodeList are sound

Adding <coins.h> matches the later use of Coin and ExtractDestination, and qt/guiutil_font.h is required for g_font_registry. The new setFont calls for the DIP3 header and filter labels are correct and applied via the existing GUIUtil::updateFonts() call at the end of the constructor.

Also applies to: 43-47, 94-95

src/qt/signverifymessagedialog.cpp (1)

11-12: Ctor font registry setup is consistent

Including qt/guiutil_font.h and using g_font_registry for the signature fields and status labels (with size and boolean flag where needed) fits the new font subsystem and is applied via the existing GUIUtil::updateFonts() call.

Also applies to: 57-61

src/qt/governancelist.cpp (2)

21-21: LGTM!

The inclusion of qt/guiutil_font.h is necessary for the font registry API usage below.

---

315-317: LGTM!

The migration from the old FontWeight enum to the FontRegistry API is correct and consistent with the broader refactoring.

src/qt/optionsmodel.cpp (4)

15-15: LGTM!

The inclusion of qt/guiutil_font.h is necessary for the font registry functionality used throughout this file.

---

100-158: LGTM!

The font initialization logic is well-structured with proper defensive fallbacks:

• Registers and sets the font family with appropriate checks
• Handles unsupported font weights by falling back to supported alternatives (lightest for normal, second lightest for bold)
• Applies all font changes via updateFonts() after configuration

---

553-560: LGTM!

The FontWeightNormal data reading correctly retrieves the weight index with proper fallback to the default weight when the current weight isn't in the supported list.

---

561-568: LGTM!

The font weight data access logic (both reading and writing) correctly handles the conversion chain between UI indices, QFont::Weight values, and persistent storage format.

Also applies to: 805-817

src/qt/guiutil_font.h (6)

1-17: LGTM!

The header structure is correct with proper includes and header guards. The necessary <map> header is present.

---

18-32: LGTM!

The namespace constants, FontWeight enum, and FontAttrib struct are well-defined with appropriate defaults.

---

34-49: LGTM!

The FontInfo struct is well-designed with explicit construction requirements and appropriate encapsulation of weight calculation methods.

---

51-122: LGTM!

The FontRegistry class API is well-designed with:

• Platform-specific constants for macOS font weight handling
• Consistent setter/getter interface
• Defensive fallbacks in getters while maintaining fail-fast assertions in setters (per established pattern)
• Proper encapsulation of font state

Based on learnings, the intentional use of assert() in setters enforces invariants during development.

---

124-159: LGTM!

The external declarations and free function APIs provide a complete and coherent font management interface.

---

1-161: Ensure code conforms to clang-format standards.

Run the provided command to verify and apply formatting rules to this file.

Reviewing files that changed from the base of the PR and between 14137c6 and 6d2c2d9.

• src/Makefile.qt.include
• src/qt/addressbookpage.cpp
• src/qt/addresstablemodel.cpp
• src/qt/appearancewidget.cpp
• src/qt/appearancewidget.h
• src/qt/askpassphrasedialog.cpp
• src/qt/bitcoin.cpp
• src/qt/bitcoingui.cpp
• src/qt/coincontroldialog.cpp
• src/qt/governancelist.cpp
• src/qt/guiutil.cpp
• src/qt/guiutil.h
• src/qt/guiutil_font.cpp
• src/qt/guiutil_font.h
• src/qt/masternodelist.cpp
• src/qt/modaloverlay.cpp
• src/qt/openuridialog.cpp
• src/qt/optionsdialog.cpp
• src/qt/optionsmodel.cpp
• src/qt/overviewpage.cpp
• src/qt/proposalwizard.cpp
• src/qt/qrdialog.cpp
• src/qt/qrimagewidget.cpp
• src/qt/receivecoinsdialog.cpp
• src/qt/receiverequestdialog.cpp
• src/qt/rpcconsole.cpp
• src/qt/sendcoinsdialog.cpp
• src/qt/sendcoinsentry.cpp
• src/qt/signverifymessagedialog.cpp
• src/qt/splashscreen.cpp
• src/qt/test/apptests.cpp
• src/qt/trafficgraphwidget.cpp
• src/qt/transactiondescdialog.cpp
• src/qt/utilitydialog.cpp
• src/qt/walletview.cpp
• test/util/data/non-backported.txt

• src/qt/guiutil.h

• src/qt/addressbookpage.cpp
• src/qt/receiverequestdialog.cpp
• src/qt/test/apptests.cpp
• src/qt/modaloverlay.cpp
• src/qt/addresstablemodel.cpp
• src/qt/splashscreen.cpp
• src/qt/bitcoingui.cpp
• src/qt/trafficgraphwidget.cpp
• src/qt/sendcoinsentry.cpp
• src/qt/rpcconsole.cpp
• src/qt/proposalwizard.cpp
• src/qt/appearancewidget.h
• src/qt/transactiondescdialog.cpp
• src/qt/overviewpage.cpp
• src/qt/qrimagewidget.cpp
• src/Makefile.qt.include
• src/qt/utilitydialog.cpp
• src/qt/sendcoinsdialog.cpp
• src/qt/openuridialog.cpp
• src/qt/governancelist.cpp
• src/qt/walletview.cpp
• test/util/data/non-backported.txt

• GitHub Check: linux64_nowallet-build / Build source
• GitHub Check: win64-build / Build source
• GitHub Check: linux64_ubsan-build / Build source
• GitHub Check: linux64_fuzz-build / Build source
• GitHub Check: linux64-build / Build source
• GitHub Check: linux64_sqlite-build / Build source
• GitHub Check: arm-linux-build / Build source
• GitHub Check: mac-build / Build source
• GitHub Check: linux64_tsan-build / Build source

src/qt/guiutil.cpp (1)

300-301: LGTM! Font calls correctly migrated to FontRegistry API.

The font setting calls have been properly updated to use the new FontAttrib struct syntax with registry-based weights. The italic flag on line 301 correctly uses the third parameter.

src/qt/askpassphrasedialog.cpp (1)

15-15: LGTM! Consistent font registry migration.

The include and font-setting call properly use the new FontRegistry API.

Also applies to: 34-34

src/qt/optionsdialog.cpp (1)

17-17: LGTM! Proper FontRegistry integration.

All font-setting calls correctly use the registry-based weights with the FontAttrib struct syntax.

Also applies to: 53-53, 400-401

src/qt/bitcoin.cpp (2)

664-677: LGTM! Robust font loading with proper error handling.

The font loading logic properly handles failures:

• Fatal error with clear message if loadFonts() fails
• Font registration and setting are both validated
• User-friendly error message displays the problematic font name

This addresses the past review concern about crashes with invalid fonts.

---

678-711: LGTM! Complete font configuration with validation.

All font parameters (weight-normal, weight-bold, font-scale) are properly validated with:

• Clear error messages showing valid ranges
• Registry-based setters
• Final font application via updateFonts() and setApplicationFont()

src/qt/qrdialog.cpp (1)

11-11: LGTM! Standard font registry migration.

The include and font-setting call are consistent with the FontRegistry pattern used throughout the PR.

Also applies to: 24-24

src/qt/coincontroldialog.cpp (1)

16-16: LGTM! Consistent FontRegistry usage.

The font-setting call properly uses g_font_registry.GetWeightBold() with the FontAttrib struct.

Also applies to: 61-61

src/qt/receivecoinsdialog.cpp (1)

10-10: LGTM! Proper FontRegistry integration.

Both font-setting calls correctly use registry-based weights with appropriate sizes and widget lists.

Also applies to: 26-29

src/qt/masternodelist.cpp (2)

45-46: Font weight migration looks good.

The transition from GUIUtil::FontWeight::Bold/Normal to GUIUtil::g_font_registry.GetWeightBold()/GetWeightNormal() correctly adopts the new registry-based font management pattern.

---

8-8: No action required for coins.h include.

The #include <coins.h> is necessary—the Coin type is used in the file (line 182).

Likely an incorrect or invalid review comment.

src/qt/signverifymessagedialog.cpp (1)

11-11: LGTM! Registry-based font weights correctly applied.

The include addition and migration of font weight access to GUIUtil::g_font_registry.GetWeightNormal()/GetWeightBold() is consistent with the refactoring pattern across the codebase.

Also applies to: 57-59, 115-116

src/qt/appearancewidget.cpp (3)

23-28: Good state preservation pattern.

The constructor correctly captures the initial font registry state (theme, scale, font family, and both weight values) for potential restoration in the destructor. This ensures preview changes can be rolled back if not accepted.

---

64-80: Proper state restoration on reject.

The destructor correctly restores all font-related settings to their previous values when !fAcceptChanges, ensuring preview changes are rolled back. The sequence of restoring font, scale, and weights followed by updateFonts() is appropriate.

---

165-165: Verify fallback condition logic.

The condition checks !IsValidWeight(prevWeightNormal) || !IsValidWeight(prevWeightBold) to decide whether to reset to defaults. Ensure this correctly handles edge cases where only one of the two weights is invalid, since the code resets both to defaults even if only one is invalid.

src/qt/optionsmodel.cpp (5)

126-131: Solid fallback logic for unsupported normal weights.

The code correctly validates whether the configured normal weight is supported by the current font. If not, it falls back to the lightest supported weight (GetSupportedWeights().front()), ensuring a valid weight is always set. This prevents crashes from assertion failures mentioned in the PR description.

---

143-150: Good fallback for bold weights with preference for heavier weight.

The bold weight fallback uses the second lightest weight when available, or falls back to the lightest if only one weight is supported. This maintains a visual distinction between normal and bold when possible.

---

156-158: Explicit font update application is necessary.

Calling GUIUtil::updateFonts() after all font settings are initialized ensures the registry state is propagated to all widgets. This is the correct pattern for applying font configuration changes.

---

554-559: Handle invalid weight index gracefully.

The code returns a fallback default index when WeightToIdx() returns -1. However, the subsequent assert(nIndex != -1) will still trigger if both the configured weight and the default weight are invalid. Consider whether the assertion is appropriate here or if additional defensive logic is needed.

Based on learnings, assertions are intentional for enforcing invariants during development.

---

103-105: The font registry is designed to handle failures gracefully. RegisterFont() returns false if a font doesn't exist, and SetFont() checks the precondition before modifying state. The code uses short-circuit evaluation—if either call fails, setApplicationFont() is never invoked, allowing the application to continue with its previous font. No inconsistent state is possible.

Likely an incorrect or invalid review comment.

src/qt/guiutil_font.cpp (6)

186-204: Clever weight detection via text width measurement.

The CalcSupportedWeights method uses an innovative approach: rendering test text at different weights and measuring width differences to determine which weights the font actually supports. This is more robust than relying on font metadata alone.

---

232-238: Smart differentiation between normal and bold defaults.

When the best matches for normal and bold target weights are identical, the code automatically selects the next heavier weight for bold. This ensures visual distinction between the two font weights even when exact matches aren't available.

---

315-325: Platform-specific font handling is appropriate.

The macOS-specific logic for Montserrat font application (using getFontNormal() when weight differs from target, or setting weight directly) correctly handles platform differences in font naming and weight handling.

---

363-382: Proper cleanup of invalid widget references.

The code correctly uses QPointer::isNull() to detect deleted widgets and removes their entries from both mapWidgetDefaultFontSizes and mapFontUpdates. This prevents memory leaks and stale references.

---

454-475: Platform-dependent Montserrat font construction.

The code handles platform differences in Montserrat font application:

• macOS: Uses setStyleName() with variant names (e.g., "Bold Italic")
• Other platforms: Uses family name concatenation for non-Normal/Bold weights

This approach accommodates Qt's platform-specific font handling behavior. Ensure this has been tested on both macOS and Linux/Windows platforms.

---

263-267: Verify font loading failure handling in test code.

The main application code in bitcoin.cpp:664-667 properly handles loadFonts() failure by checking the return value and displaying a critical error before exiting. However, the test code in apptests.cpp:82 calls loadFonts() without checking its return value. Verify that test code either handles the failure case or explicitly documents why it's safe to proceed without checking.

Reviewing files that changed from the base of the PR and between 19344a0 and db3d1b8.

• src/qt/appearancewidget.cpp
• src/qt/appearancewidget.h
• src/qt/askpassphrasedialog.cpp
• src/qt/bitcoin.cpp
• src/qt/bitcoingui.cpp
• src/qt/coincontroldialog.cpp
• src/qt/governancelist.cpp
• src/qt/guiutil.cpp
• src/qt/guiutil_font.cpp
• src/qt/guiutil_font.h
• src/qt/masternodelist.cpp
• src/qt/modaloverlay.cpp
• src/qt/optionsdialog.cpp
• src/qt/optionsmodel.cpp
• src/qt/optionsmodel.h
• src/qt/overviewpage.cpp
• src/qt/proposalwizard.cpp
• src/qt/qrdialog.cpp
• src/qt/receivecoinsdialog.cpp
• src/qt/rpcconsole.cpp
• src/qt/sendcoinsdialog.cpp
• src/qt/sendcoinsentry.cpp
• src/qt/signverifymessagedialog.cpp
• src/qt/test/apptests.cpp
• src/qt/trafficgraphwidget.cpp
• src/qt/walletview.cpp

• src/qt/optionsdialog.cpp

• src/qt/governancelist.cpp
• src/qt/sendcoinsdialog.cpp
• src/qt/appearancewidget.h
• src/qt/rpcconsole.cpp
• src/qt/sendcoinsentry.cpp
• src/qt/modaloverlay.cpp
• src/qt/receivecoinsdialog.cpp
• src/qt/overviewpage.cpp
• src/qt/trafficgraphwidget.cpp
• src/qt/askpassphrasedialog.cpp
• src/qt/walletview.cpp

• GitHub Check: linux64_multiprocess / Build depends
• GitHub Check: win64-build / Build source
• GitHub Check: linux64_fuzz-build / Build source
• GitHub Check: linux64_ubsan-build / Build source
• GitHub Check: linux64_sqlite-build / Build source
• GitHub Check: linux64-build / Build source
• GitHub Check: arm-linux-build / Build source
• GitHub Check: mac-build / Build source
• GitHub Check: linux64_nowallet-build / Build source
• GitHub Check: Lint / Run linters
• GitHub Check: predict_conflicts

src/qt/guiutil_font.cpp (9)

110-115: LGTM: Helper function for formatted debug output.

The qstrprintf template wrapper is clean and serves its purpose well for converting tinyformat output to QString for debug logging.

---

127-135: LGTM: FontInfo initialization is correct.

The constructor properly calculates supported and default weights before initializing the weight members. The defaulted destructor is appropriate.

---

137-157: LGTM: Font registration logic is sound.

The registration flow correctly checks for existing fonts, validates availability when needed, and maintains consistency between m_weights and g_fonts_known.

---

168-182: LGTM: Weight conversion functions are consistent.

weightFromArg provides safe conversion with error checking, while weightToArg uses an assert to enforce the invariant that only valid weights are converted. This aligns with the established pattern in the codebase.

Based on learnings, this fail-fast approach is intentional.

---

241-298: LGTM: Font loading logic is comprehensive.

The function correctly:

• Preserves the system default font
• Loads all Montserrat variants with proper error checking
• Provides extensive debug output when enabled
• Registers all known fonts after successful loading

---

305-333: LGTM: Application font setup handles platform differences correctly.

The function properly handles different font families and includes platform-specific logic for macOS, which is necessary due to Qt limitations on that platform.

---

345-440: LGTM: Font update logic is robust.

The function:

• Properly cleans up deleted widgets using QPointer
• Uses a two-phase update to avoid font inheritance issues (well documented)
• Handles both per-widget and per-class font updates
• Includes comprehensive debug output

---

442-511: LGTM: Font retrieval logic handles platform differences correctly.

The getFont functions properly handle:

• Different font families (Montserrat, OS default, custom)
• Platform-specific Montserrat handling for macOS
• Font scaling via the registry
• Optional debug output

The convenience wrappers getFontNormal() and getFontBold() provide clean API access.

---

513-529: LGTM: Weight/index conversion functions are correct.

IdxToWeight uses an assert for bounds checking (line 516), consistent with the fail-fast pattern. WeightToIdx defensively returns -1 when the weight isn't found, which is appropriate for a lookup operation.

Based on learnings, the assert is intentional.

src/qt/guiutil_font.h (3)

18-32: LGTM: Font constants and structures are well-defined.

The use of constexpr QStringView for font names is appropriate for Qt 5. The FontAttrib structure provides a clean interface for passing font properties.

---

34-122: LGTM: FontInfo and FontRegistry are well-designed.

The class design properly separates:

• Public constants and interface
• Private implementation details
• Static font defaults with platform-specific values

The setter/getter pattern (asserts in setters, defensive checks in getters) is intentional and consistent with established patterns.

Based on learnings, the assert usage is by design.

---

124-159: LGTM: Public API is clean and well-documented.

The free functions provide a comprehensive interface for:

• Weight conversion (weightFromArg, weightToArg)
• Font lifecycle (loadFonts, fontsLoaded)
• Font application (setApplicationFont, setFont, updateFonts)
• Font retrieval (getFont overloads, getFontNormal, getFontBold)

src/qt/test/apptests.cpp (2)

11-11: LGTM: Include added correctly.

The addition of <qt/guiutil_font.h> is necessary for accessing the font management APIs.

---

82-83: LGTM: Font initialization sequence is correct.

The addition of GUIUtil::setApplicationFont() after GUIUtil::loadFonts() properly completes the font initialization workflow in the test setup.

src/qt/qrdialog.cpp (1)

11-11: LGTM: Migration to registry-based font weight is correct.

The changes properly migrate from the old FontWeight::Bold enum to the new registry-based g_font_registry.GetWeightBold() API, maintaining the same functional behavior.

Also applies to: 24-24

src/qt/optionsmodel.h (1)

117-117: LGTM: Helper method for checking command-line overrides.

The isOptionOverridden() method provides a clean interface for querying whether a specific option was overridden via command-line arguments, complementing the existing getOverriddenByCommandLine() method.

src/qt/guiutil.cpp (1)

300-301: LGTM: setupAppearance migrated to registry-based font API.

The font weight retrieval correctly uses the new registry-based API (g_font_registry.GetWeightBold() and g_font_registry.GetWeightNormal()), maintaining the same functional behavior while using the centralized font management system.

src/qt/proposalwizard.cpp (1)

16-16: LGTM: Font weight migration is correct.

The changes properly migrate from the enum-based font weight to the registry-based API, maintaining consistent behavior.

Also applies to: 47-47

src/qt/coincontroldialog.cpp (1)

16-16: LGTM: Font weight migration completed correctly.

The changes properly migrate to the registry-based font weight API. The setFont call now uses g_font_registry.GetWeightBold() in place of the old enum value.

Also applies to: 55-61

src/qt/bitcoingui.cpp (3)

13-13: Font registry include wiring looks correct

Including <qt/guiutil_font.h> here is appropriate now that this file uses GUIUtil::g_font_registry and GUIUtil::setFont with FontAttrib.

---

760-762: Toolbar tab font initialization correctly uses registry weights

Using GUIUtil::setFont({button}, {GUIUtil::g_font_registry.GetWeightNormal(), 16}); aligns with the new FontAttrib API and centralizes the actual weight mapping in FontRegistry.

---

1239-1243: Tab highlight logic now registry‑driven and consistent

highlightTabButton correctly switches between GetWeightBold() / GetWeightNormal() and defers actual application to GUIUtil::updateFonts(), matching the new global font update model.

src/qt/masternodelist.cpp (2)

8-12: Includes updated appropriately for Coin and font registry

Adding <coins.h> for Coin and <qt/guiutil_font.h> for GUIUtil::g_font_registry makes the dependencies explicit and avoids relying on transitive includes.

---

43-47: Label fonts migrated cleanly to FontRegistry

The two GUIUtil::setFont calls now use GetWeightBold() / GetWeightNormal() with explicit point sizes, matching the registry‑driven font system and keeping the construction simple.

src/qt/signverifymessagedialog.cpp (3)

11-11: Header dependency for font registry is correctly added

Including <qt/guiutil_font.h> is required now that this dialog uses g_font_registry via GUIUtil::setFont.

---

57-60: Dialog font styling correctly migrated to FontRegistry

The new setFont calls for signature fields and status labels use GetWeightNormal() / GetWeightBold() with appropriate sizes and italics, matching the shared font configuration semantics.

---

107-117: Active/inactive tab button fonts are updated in a registry‑safe way

showPage() now styles the active button with GetWeightBold() and the others with GetWeightNormal(), then calls GUIUtil::updateFonts(). This is consistent with the centralized font update pipeline.

src/qt/appearancewidget.cpp (8)

23-28: Capturing previous appearance state in the ctor is a good safeguard

Initializing prevTheme, prevScale, prevFontFamily, prevWeightNormal, and prevWeightBold from GUIUtil::getActiveTheme() / g_font_registry at construction time provides a robust basis for later rollback on cancel.

---

36-40: Font family list is now registry‑driven

Populating fontFamily from GUIUtil::g_fonts_known with the index as userData keeps the combo box in sync with the registry’s notion of known fonts and avoids hard‑coded entries.

---

87-135: Model mapping and CLI override handling look consistent

setModel:

• Attaches a QDataWidgetMapper for theme, font family, scale, and weights.
• Uses QSignalBlocker to avoid triggering update slots during initial population.
• Disables and forces values for fontFamily, fontScaleSlider, and the weight sliders when the respective -font-* options are overridden on the command line.
• Uses registry helpers (WeightToIdx, GetWeight*) so sliders always reflect a valid weight index.

This structure keeps UI state, options, and the registry coherent, and correctly respects CLI overrides.

---

155-161: Font family updates correctly validate via registry and apply fonts

updateFontFamily sets the font through g_font_registry.SetFont(...) with an assert on the returned bool, then calls setApplicationFont() and updateFonts(), followed by updateWeightSlider(true).

This matches the preferred fail‑fast style for invariants while ensuring the UI immediately reflects the change.

---

164-168: Font scale updates are applied through the registry and global updater

updateFontScale delegates to g_font_registry.SetFontScale(nScale) and then calls GUIUtil::updateFonts(), which is exactly what’s needed to rescale existing widgets without reinitializing the registry.

---

170-181: Normal weight slider logic enforces ordering and syncs with registry

updateFontWeightNormal:

• Enforces normal <= bold unless fForce is true.
• Uses QSignalBlocker on the slider to avoid recursion.
• Updates g_font_registry via IdxToWeight(...) and then reapplies the application font and widget fonts.

The symmetry with updateFontWeightBold keeps the weight range invariant intact.

---

183-194: Bold weight slider logic mirrors normal weight handling

updateFontWeightBold mirrors the normal path, enforcing bold >= normal and updating both the slider and the registry + fonts in one place, which keeps the two sliders tightly coupled and avoids impossible configurations.

---

196-212: Weight slider limits and defaulting behavior are reasonable

updateWeightSlider:

• Sets both sliders’ min/max based on GetSupportedWeights().size() - 1.
• When forced, or when previous weights are invalid, reinitializes to registry default normal/bold weights via WeightToIdx(GetWeight*Default()) and the updateFontWeight* helpers.

This ensures the UI always reflects a valid index range and gracefully recovers from unsupported stored weights.

src/qt/optionsmodel.cpp (5)

15-15: Font utilities header inclusion is appropriate

Including <qt/guiutil_font.h> here is necessary now that OptionsModel interacts with GUIUtil::FontRegistry and helpers like weightFromArg / weightToArg.

---

100-171: Font family/scale/weight initialization is now registry‑centric and robust

The new initialization logic:

• Seeds fontFamily, fontScale, and both weights from FontRegistry defaults when missing.
• Uses SoftSetArg + addOverriddenOption to track CLI overrides.
• Calls GUIUtil::fontsLoaded() before touching g_font_registry, then:
  • Registers/sets the family.
  • Applies the font scale from CLI/settings.
  • For weights, initializes QFont::Weight to GetWeight*Default(), optionally overrides from CLI/settings via weightFromArg, and falls back to supported weights if the chosen weight isn’t available for the current font.
• Finishes by calling GUIUtil::setApplicationFont() once.

This fully addresses the earlier uninitialized‑weight issue and gracefully handles corrupted or unsupported stored weights.

---

133-167: CLI font‑family override interaction with weights is handled sensibly

Using override_family{isOptionOverridden("-font-family")} and only applying weightFromArg when either the family is not CLI‑overridden or the specific weight option is overridden gives:

• Default weights for arbitrary fonts chosen via CLI -font-family, unless the user also explicitly overrides weights.
• Validated, range‑checked weights via IsValidWeight + GetSupportedWeights() fallback.

This matches the intended separation of duties between family and weight options.

---

566-579: data() for font weights now safely defaults and uses registry mapping

For FontWeightNormal / FontWeightBold:

• weight is initialized from GetWeight*Default().
• weightFromArg optionally adjusts it from stored settings.
• The resulting weight is mapped to a slider index via WeightToIdx, with an assert ensuring a valid mapping.

This avoids undefined behavior on malformed settings and keeps the UI in sync with the registry’s supported weights.

---

816-829: setData() correctly translates slider indices back to stored weight args

In setData:

• The slider index is converted to a QFont::Weight via IdxToWeight.
• That weight is serialized to an integer arg with weightToArg and written to QSettings.

This keeps the persistent representation aligned with the registry’s internal mapping and with the CLI parsing (weightFromArg).

src/qt/bitcoin.cpp (5)

25-25: Font registry header is correctly added to the Qt entry point

Including <qt/guiutil_font.h> here is required now that GuiMain manipulates the global FontRegistry directly for CLI validation and application.

---

485-492: UI args for fonts are now documented from registry defaults

The updated SetupUIArgs:

• Uses Join(GUIUtil::g_fonts_known, ", ") for the -font-family help text.
• References FontRegistry::DEFAULT_FONT, DEFAULT_FONT_SCALE, and TARGET_WEIGHT_* via weightToArg(...) for defaults.

This keeps CLI help aligned with the registry’s actual capabilities and default configuration.

Please just double‑check that Join(GUIUtil::g_fonts_known, ", ") and the %1 substitution work as expected with the concrete type of g_fonts_known in your tree; if not, QStringList::join(", ") may be a simpler alternative.

---

664-667: Early abort on font loading failure is appropriate

Bailing out with a critical message box when GUIUtil::loadFonts() fails prevents the app from running with partially initialized font state, which is safer than attempting to continue.

---

669-677: CLI font‑family validation now fails fast with a clear error

After loading fonts and creating the options model, the -font-family argument is revalidated via RegisterFont and SetFont, with a user‑facing error and EXIT_FAILURE on failure. This addresses prior crash scenarios when an invalid family was passed on the command line.

---

679-711: CLI validation for weights and scale is thorough and consistent

The new blocks:

• Parse -font-weight-normal / -font-weight-bold with weightFromArg, erroring out on invalid values before using the result.
• Parse -font-scale and enforce [-100, 100], exiting on out‑of‑range values.
• Apply validated values to g_font_registry and finally call GUIUtil::updateFonts() followed by GUIUtil::setApplicationFont().

This gives a clean, deterministic startup path for font CLI options and avoids undefined behavior from malformed arguments.