-
Notifications
You must be signed in to change notification settings - Fork 1.2k
docs: add build badge from GitHub Actions runs on master and develop
#6663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe README.md file was updated to expand the badges section. The section now includes both GitHub Actions and GitLab CI badges for the master and develop branches. A table format with clear headers ("Source", "master", "develop") was introduced to organize the badges. URLs for the GitHub Actions badges were added, pointing to the relevant GitHub repository, while the existing GitLab CI badge links remain unchanged. No other content or links in the README.md file were modified. No changes were made to any exported or public entities in the codebase. Tip ⚡️ Faster reviews with caching
Enjoy the performance boost—your workflow just got faster. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📥 CommitsReviewing files that changed from the base of the PR and between 43696687c6e5b09492a8c3147739165abf5c12b3 and b8236c8. 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between 8732326 and d7af338629058f9794212683aec41477eaeacc69.
📒 Files selected for processing (1)
README.md(1 hunks)
UdjinM6
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK 43696687c6e5b09492a8c3147739165abf5c12b3
PastaPastaPasta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK 43696687c6e5b09492a8c3147739165abf5c12b3
Co-authored-by: UdjinM6 <[email protected]>
UdjinM6
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, utACK b8236c8
…s badge from README 8f86e1b chore: remove GitLab CI configuration file, remove status from README (Kittywhiskers Van Gogh) Pull request description: ## Additional Information As we are decommissioning our GitLab CI runners (which made their debut in [dash#3149](#3149) in 2019) in favour of GitHub Actions (which as noted in [dash#6663](#6663) is now at feature-parity with GitLab CI), this pull request removes the `.gitlab-ci.yml` configuration and updates our badges in `README.md` to reflect this change. Gone but not forgotten. Sayonara, GitLab CI! 2019-2025. ## How Has This Been Tested?  ## Checklist - [x] I have performed a self-review of my own code **(note: N/A)** - [x] I have commented my code, particularly in hard-to-understand areas **(note: N/A)** - [x] I have added or updated relevant unit/integration/functional/e2e tests **(note: N/A)** - [x] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ ACKs for top commit: PastaPastaPasta: utACK 8f86e1b thephez: utACK 8f86e1b UdjinM6: utACK 8f86e1b Tree-SHA512: 3dce3de4adfb7b769f8c360699711686c6360e7f48769a0b962d401189ce042f7c398f91d3dcc046d723667ba048732b3d74c5f3ee8fd12e17a19fbfe8124991
Motivation
Since dash#6604, we haven't seen GitHub Actions runners experience sporadic failures that aren't the result of test failures. In comparison, GitLab CI has been showing greater instability with its runners (build, build).
As GitHub Actions runners are now at coverage parity with GitLab CI, this pull request adds status badges for it in the same vein as dash#3915.
How Has This Been Tested?
Checklist