Skip to content

Conversation

@knst
Copy link
Collaborator

@knst knst commented Dec 3, 2024

Issue being fixed or feature implemented

Follow-up for #6441

What was done?

Pass reference to CWallet instead const reference to smart pointer with CWallet to CTransactionBuilder.

How Has This Been Tested?

Run unit/functional tests

Breaking Changes

N/A

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone

@knst knst added this to the 22.1 milestone Dec 3, 2024
@knst knst force-pushed the refactor-ctransactionbuilder branch from d7daf4d to 43778b0 Compare December 3, 2024 18:00
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 43778b0

Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 43778b0

@PastaPastaPasta PastaPastaPasta merged commit e482d18 into dashpay:develop Dec 10, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants