guix: build only supported targets using guix-start, update guix-start and guix-check to work correctly outside of containers
#6390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
kwvg
reviewed
Nov 11, 2024
UdjinM6
force-pushed
the
pr_6382_fu_2
branch
from
e8aea70 to
43e7985
Compare
kwvg
previously approved these changes
Nov 11, 2024
Collaborator
kwvg
left a comment
kwvg
left a comment
There was a problem hiding this comment.
ACK 43e79851fce4ef12e4bfa1f68d30ac56f496a2ac
knst
reviewed
Nov 12, 2024
UdjinM6
force-pushed
the
pr_6382_fu_2
branch
from
43e7985 to
a9c9faa
Compare
knst
previously approved these changes
Nov 12, 2024
Collaborator
knst
left a comment
knst
left a comment
There was a problem hiding this comment.
LGTM a9c9faa008212d32d165bf035b5353047887c3af
UdjinM6
force-pushed
the
pr_6382_fu_2
branch
from
a9c9faa to
7c24586
Compare
Author
|
Applied suggestions and also added 3ac5739 so local usage is now as simple as |
UdjinM6
force-pushed
the
pr_6382_fu_2
branch
from
7c24586 to
74489dc
Compare
UdjinM6
changed the title
guix-start, update guix-start and guix-check to work correctly outside of containers
kwvg
reviewed
Nov 12, 2024
kwvg
reviewed
Nov 13, 2024
Collaborator
kwvg
left a comment
kwvg
left a comment
There was a problem hiding this comment.
Running the script prints with an argument prints the value of ${1} before execution, this behaviour doesn't occur when it defaults to $(pwd)
$ ./contrib/containers/guix/scripts/guix-start
Found macOS SDK at '/src/dash/depends/SDKs/Xcode-12.2-12B45b-extracted-SDK-with-libcxx-headers', using...
Checking that we can connect to the guix-daemon...
^C
[...]
$ ./contrib/containers/guix/scripts/guix-start $(pwd)
/src/dash
Found macOS SDK at '/src/dash/depends/SDKs/Xcode-12.2-12B45b-extracted-SDK-with-libcxx-headers', using...
Checking that we can connect to the guix-daemon...
^C
[...]
| if [[ ! -d "$WORKSPACE_PATH" ]]; then | ||
| echo "$0: $WORKSPACE_PATH is not a valid directory, exiting!" | ||
| if [[ ! -d "${WORKSPACE_PATH}" || ! "${WORKSPACE_PATH}" = /* || ! -f "${WORKSPACE_PATH}/contrib/guix/libexec/prelude.bash" ]]; then | ||
| echo "${0}: ${WORKSPACE_PATH} is not a valid directory, exiting!" |
Collaborator
There was a problem hiding this comment.
The message printed seems unwieldy, could be resolved by replacing ${0} with ${0##*/}
Before:
$ ./contrib/containers/guix/scripts/guix-start /
./contrib/containers/guix/scripts/guix-start: / is not a valid directory, exiting!
After:
./contrib/containers/guix/scripts/guix-start /
guix-start: / is not a valid directory, exiting!
Maybe error message should be tweaked? It is a valid directory, just the wrong directory.
kwvg
approved these changes
Nov 14, 2024
5 tasks
PastaPastaPasta
added a commit
that referenced
this pull request
Nov 26, 2024
…rocess.md` 87c31ad Update doc/release-process.md (UdjinM6) 55d7463 docs: mention building for some HOSTs only in `release-process.md` (UdjinM6) Pull request description: ## Issue being fixed or feature implemented dashpay/guix.sigs#73 #6390 follow-up ## What was done? ## How Has This Been Tested? ## Breaking Changes ## Checklist: - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [ ] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ Top commit has no ACKs. Tree-SHA512: b4a2cadf5899a8aea6612b4ff9c0e9f9c530a9e2344eb090967fbcf9a2ab219aff02f11f86434e4082f84c401d578cf2d033b6838c94705f532beca4ab604986
knst
pushed a commit
to knst/dash
that referenced
this pull request
Nov 26, 2024
…lease-process.md` 87c31ad Update doc/release-process.md (UdjinM6) 55d7463 docs: mention building for some HOSTs only in `release-process.md` (UdjinM6) Pull request description: ## Issue being fixed or feature implemented dashpay/guix.sigs#73 dashpay#6390 follow-up ## What was done? ## How Has This Been Tested? ## Breaking Changes ## Checklist: - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [ ] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ Top commit has no ACKs. Tree-SHA512: b4a2cadf5899a8aea6612b4ff9c0e9f9c530a9e2344eb090967fbcf9a2ab219aff02f11f86434e4082f84c401d578cf2d033b6838c94705f532beca4ab604986
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
#6382 (comment) #6388 (comment)
alternative to #6388
What was done?
How Has This Been Tested?
Breaking Changes
Checklist: