backport: merge bitcoin-core/gui#337, #354, #317, #349, #403, #418, #416, #449, #477, #563, #554, #615 (qt backports: part 2) #6337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwvg
changed the title
…ime::fromSecsSinceEpoch
|
This pull request has conflicts, please rebase. |
PastaPastaPasta
previously approved these changes
Oct 24, 2024
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK 1662905dfbb2ba0b05faa4b2c8bae987b9a358ee
UdjinM6
requested changes
Oct 24, 2024
knst
reviewed
Oct 24, 2024
| if (datetime < dateFrom || datetime > dateTo) | ||
| return false; | ||
|
|
||
| QDateTime datetime = index.data(TransactionTableModel::DateRole).toDateTime(); |
Collaborator
There was a problem hiding this comment.
it used to be a qint64 for a reason: QDateTime had performance issues, accordingly #3155
Though, it is replaced to in next backport bitcoin-core/gui#349 to fromSecsSinceEpoch
Qt's doc says:
Returns a datetime whose date and time are the number of seconds secs that have passed since 1970-01-01T00:00:00.000, Coordinated Universal Time (Qt::UTC) and converted to the given spec.
I guess there's not more performance degradation.
If any objection, there's qint64: knst@c0cafa3cae
knst
previously approved these changes
Oct 25, 2024
Collaborator
knst
left a comment
knst
left a comment
There was a problem hiding this comment.
utACK 15bd92a9a7725d2944e52c432a69042f51e652e1
…llet statuses simpler
…tem login" option
…ooltips for peers tab address fields
UdjinM6
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional Information
develop(3a18f08)Breaking changes
None observed.
Checklist