backport: bump boost min #6313
Merged
backport: bump boost min #6313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UdjinM6
reviewed
Oct 4, 2024
PastaPastaPasta
force-pushed
the
backport/bump-boost-min
branch
from
facd1fb to
b7b48cd
Compare
UdjinM6
requested changes
Oct 4, 2024
UdjinM6
left a comment
UdjinM6
left a comment
There was a problem hiding this comment.
debug build fails for me with
test/util/setup_common.cpp:444:9: error: use of undeclared identifier 'BOOST_ASSERT'
444 | BOOST_ASSERT(cbTx.has_value());
| ^
test/util/setup_common.cpp:447:13: error: use of undeclared identifier 'BOOST_ASSERT'
447 | BOOST_ASSERT(false);
| ^
test/util/setup_common.cpp:450:13: error: use of undeclared identifier 'BOOST_ASSERT'
450 | BOOST_ASSERT(false);
| ^
backporting 24395 (23a4d5d9) fixes it.
|
Hmm... lots of failures in CI.. there must be smth else then. Also, it looks like 24395 caused high CPU usage bitcoin#27586 and was reverted in 27724... so we need that too (or drop 24395 for now) 🙈 |
|
let's try 27783 (887241a)? |
UdjinM6
force-pushed
the
backport/bump-boost-min
branch
from
387d021 to
3147e67
Compare
|
This pull request has conflicts, please rebase. |
…alization 0d01272 build: don't use Boost multi_index serialization (fanquake) Pull request description: We don't use the serialization or archiving facilities of multi_index. So globally disable support, which gives a minor improvement in build time, i.e less preprocessing work, given we don't link any Boost libs. See: https://www.boost.org/doc/libs/1_78_0/libs/multi_index/doc/tutorial/creation.html > Serialization capabilities are automatically provided by just linking with the appropriate Boost.Serialization library module: it is not necessary to explicitly include any header from Boost.Serialization, apart from those declaring the type of archive used in the process. If not used, however, serialization support can be disabled by globally defining the macro BOOST_MULTI_INDEX_DISABLE_SERIALIZATION. Disabling serialization for Boost.MultiIndex can yield a small improvement in build times, and may be necessary in those defective compilers that fail to correctly process Boost.Serialization headers. ACKs for top commit: MarcoFalke: cr ACK 0d01272 Tree-SHA512: 87c664a2f142dc6b8f8598341f9829be3fda8cf614d73cc9a894c8033ee40c6daa9b50f4049ecb1f1e3aaf342568d9a5f5c65af1e04c36ee3a9cb46eca95767b
…tion to C++20 49a9091 build: Bump minimum required Boost to 1.73.0 to support C++20 (Hennadii Stepanov) Pull request description: Boost versions <1.73 have C++20-specific bugs that were fixed in the following commits: - boostorg/signals2@15fcf21 - boostorg/test@495c095 I tested [`libboost1.71-dev`](https://packages.ubuntu.com/focal/libboost1.71-dev) in Ubuntu 20.04 and Boost 1.71, 1.72, 1.73 in our depends build system. Closes bitcoin#29063. ACKs for top commit: fanquake: ACK 49a9091 Tree-SHA512: b8ebc08af85abfa3fda70961bd1136ee9e5149dd76a3f901e43acba624d231971873cba5cbf30837f9e5ab58790b8330f241a76cb76d8cf5dce5ad0cca33fba8
2484cac Add public Boost headers explicitly (Hennadii Stepanov) fade2ad test: Avoid `BOOST_ASSERT` macro (Hennadii Stepanov) Pull request description: To check symbols in the code base, run: ``` git grep boost::multi_index::identity git grep boost::multi_index::indexed_by git grep boost::multi_index::tag git grep boost::make_tuple ``` Hoping on the absence of conflicts with top-prio PRs :) ACKs for top commit: MarcoFalke: lgtm ACK 2484cac TheCharlatan: ACK 2484cac Tree-SHA512: d122ab028eee76ee1c4609ed51ec8db0c8c768edcc2ff2c0e420a48e051aa71e99748cdb5d22985ae6d97c808c77c1a27561f0715f77b256f74c1c310b37694c
PastaPastaPasta
force-pushed
the
backport/bump-boost-min
branch
from
3147e67 to
c0154c0
Compare
UdjinM6
approved these changes
Oct 8, 2024
knst
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
See commit
What was done?
How Has This Been Tested?
Breaking Changes
Checklist:
Go over all the following points, and put an
xin all the boxes that apply.