Skip to content

Conversation

@kwvg
Copy link
Collaborator

@kwvg kwvg commented Sep 13, 2024

Additional Information

As part of dash#6254, bitcoin#26847 was backported and since then, it was observed that unit tests were flakier than expected (build, build).

The flakiness was caused by behavior introduced by the aforementioned backport, this was resolved upstream with bitcoin#27015, which this pull request contains.

Breaking Changes

None observed.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas (note: N/A)
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation (note: N/A)
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@kwvg kwvg added this to the 21.2 milestone Sep 13, 2024
@kwvg kwvg marked this pull request as ready for review September 13, 2024 17:59
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 925870d

Copy link
Collaborator

@knst knst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 925870d

5 minutes running, no crash

@PastaPastaPasta PastaPastaPasta merged commit d290df3 into dashpay:develop Sep 15, 2024
@UdjinM6 UdjinM6 modified the milestones: 21.2, 22 Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants