refactor: add a new flag disable_mocktime to set_test_params() #6242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
UdjinM6
reviewed
Aug 30, 2024
UdjinM6
left a comment
UdjinM6
left a comment
There was a problem hiding this comment.
Gitlab CI won't pick the branch for some reason, try rebasing/force-pushing maybe?
UdjinM6
requested changes
Aug 30, 2024
knst
force-pushed
the
refactor-disable-mocktime-flag
branch
from
f48a8a1 to
ae71455
Compare
UdjinM6
previously approved these changes
Aug 30, 2024
UdjinM6
left a comment
UdjinM6
left a comment
There was a problem hiding this comment.
LGTM, utACK ae71455a8c909465838d43188c8f394cf47b0fa3
knst
force-pushed
the
refactor-disable-mocktime-flag
branch
from
ae71455 to
5339eb6
Compare
Collaborator
Author
Force pushed due to new functional test with no-mocktime: |
knst
force-pushed
the
refactor-disable-mocktime-flag
branch
from
5339eb6 to
d21f6c8
Compare
It's better than re-implement setup_nodes each time when you want just disable mocktime. It seems more error prune and the code is shorter
… disable mocktime Credits to UdjinM6
knst
force-pushed
the
refactor-disable-mocktime-flag
branch
from
d21f6c8 to
ef4d74a
Compare
UdjinM6
approved these changes
Sep 1, 2024
kwvg
approved these changes
Sep 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
To disable mocktime you should re-implement setup_nodes(). It seems as bug-friendly solution
What was done?
This PR introduce a new flag "disable_mocktime" which can be set in
set_test_params.It seems more error prune and the code is shorter
How Has This Been Tested?
Run unit/functional tests including future changes from #6235
Breaking Changes
N/A
Checklist: