chore: deprecate an option platform-user in favour of whitelist
#6209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
UdjinM6
requested changes
Aug 13, 2024
knst
force-pushed
the
deprecate-platform-user
branch
from
1d6e86a to
668efc4
Compare
UdjinM6
previously approved these changes
Sep 3, 2024
UdjinM6
left a comment
UdjinM6
left a comment
There was a problem hiding this comment.
utACK 668efc4f1a2d700b56334f2d439ea7135223caf5
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
LGTM; gonna wait to review until 21.2 is branched off to approve / merge
knst
force-pushed
the
deprecate-platform-user
branch
from
668efc4 to
70068df
Compare
knst
force-pushed
the
deprecate-platform-user
branch
from
70068df to
e2c66ae
Compare
UdjinM6
approved these changes
Sep 26, 2024
thephez
added a commit
to thephez/dash-user-docs
that referenced
this pull request
Nov 12, 2024
thephez
added a commit
to dashpay/docs
that referenced
this pull request
Nov 12, 2024
* docs(api): update whitelist description * docs(rpc): deprecate platform user Related to dashpay/dash#6209 * docs(rpc): change example formatting * docs(rpc): add rpc queue info Describes the new "external user" queue from dashpay/dash#6045 * fix(rpc): correct code block type * style: filename * docs(rpc): link to whitelist settings from deprecated platform-user section
thephez
added a commit
to dashpay/docs
that referenced
this pull request
Dec 12, 2024
* docs(api): update whitelist description * docs(rpc): deprecate platform user Related to dashpay/dash#6209 * docs(rpc): change example formatting * docs(rpc): add rpc queue info Describes the new "external user" queue from dashpay/dash#6045 * fix(rpc): correct code block type * style: filename * docs(rpc): link to whitelist settings from deprecated platform-user section
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Hard-coded restrictions for platform-user are super-seeded by whitelist feature.
What was done?
Before actually removing feature, let's make it deprecated for now
Split from #6105
6105 - to close and re-open for next major release.
It deprecates old command line argument
-platform-userby renaming to-deprecated-platform-userHow Has This Been Tested?
See new 2 functional tests:
rpc_deprecated_platform_filter.pyandrpc_external_queue.pywhich are split fromrpc_platform_filter.pyBreaking Changes
Command line argument
-platform-useris renamed to-deprecated-platform-userChecklist: