Skip to content

fix: avoid calling functions that change wallet state inside of assert(...) #6123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PastaPastaPasta merged 1 commit into from
Jul 20, 2024
Merged

fix: avoid calling functions that change wallet state inside of assert(...) #6123

PastaPastaPasta merged 1 commit into from
Jul 20, 2024

Conversation

@UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Jul 17, 2024

Issue being fixed or feature implemented

Functions that change the state should not be called inside asserts

kudos to @kwvg for noticing #6116 (comment)

What was done?

Move them out

How Has This Been Tested?

Breaking Changes

n/a

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

kwvg
kwvg approved these changes Jul 17, 2024
View reviewed changes
Copy link
Collaborator

@kwvg kwvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, utACK 121c032

knst
knst approved these changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@knst knst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 121c032

@PastaPastaPasta
Copy link
Member

PastaPastaPasta commented Jul 18, 2024

Looks fine; should we backport this or don't bother?

@knst
Copy link
Collaborator

knst commented Jul 18, 2024

Looks fine; should we backport this or don't bother?

it woks years, maybe even 10 years. I don't feel like necessary to backport

@UdjinM6 UdjinM6 requested a review from PastaPastaPasta July 19, 2024 23:24
PastaPastaPasta
PastaPastaPasta approved these changes Jul 20, 2024
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 121c032

@PastaPastaPasta PastaPastaPasta merged commit 914a505 into dashpay:develop Jul 20, 2024
@UdjinM6 UdjinM6 added this to the 21.1 milestone Jul 23, 2024
@UdjinM6 UdjinM6 modified the milestones: 21.1, 21.2 Aug 8, 2024
@UdjinM6 UdjinM6 modified the milestones: 21.2, 22 Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@knst knst knst approved these changes

@PastaPastaPasta PastaPastaPasta PastaPastaPasta approved these changes

@kwvg kwvg kwvg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

22

Development

Successfully merging this pull request may close these issues.

4 participants

@UdjinM6 @PastaPastaPasta @knst @kwvg