Skip to content

test: disable mocktime in p2p_eviction.py #6121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PastaPastaPasta merged 1 commit into from
Aug 1, 2024
Merged

test: disable mocktime in p2p_eviction.py #6121

PastaPastaPasta merged 1 commit into from
Aug 1, 2024

Conversation

@UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Jul 17, 2024 •
edited
Loading

Issue being fixed or feature implemented

No idea why CI has no issues but p2p_eviction.py fails locally after #6103 (my guess is that it's because P2PInterface can't work with mocktime properly).

What was done?

Disable mocktime in p2p_eviction.py

How Has This Been Tested?

Run tests locally

Breaking Changes

n/a

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@UdjinM6 UdjinM6 requested review from PastaPastaPasta and knst July 19, 2024 23:23
PastaPastaPasta
PastaPastaPasta previously approved these changes Jul 20, 2024
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 35413f5d81c07e6e00d20992fdb36982b3641f64

@UdjinM6
Copy link
Author

UdjinM6 commented Jul 29, 2024

ping @knst

knst
knst reviewed Jul 29, 2024
View reviewed changes
test/functional/p2p_eviction.py Outdated
Copy link
Collaborator

@knst knst Jul 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why bitcoin has it working? let's add here TODO maybe that it is just a temporary fix?

Copy link
Author

@UdjinM6 UdjinM6 Jul 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we enable mocktime by default and bitcoin enables it for some tests only (that's also why we have to bump mocktime instead of using sleep() in many tests btw)

@knst
Copy link
Collaborator

knst commented Jul 29, 2024

CI has no issues but p2p_eviction.py fails locally after #6103 (my guess is that it's because P2PInterface can't work with mocktime properly).

that's fun, because locally p2p_eviction.py never fails on my both machines, but p2p_timeouts.py fails badly in 80% cases on my both localhosts

knst
knst approved these changes Jul 29, 2024
View reviewed changes
Copy link
Collaborator

@knst knst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 540337a4567caa22977c93608f7da7358a6fe8f3

@PastaPastaPasta
Copy link
Member

PastaPastaPasta commented Aug 1, 2024

I squashed the two commits into one; no diff

@PastaPastaPasta PastaPastaPasta merged commit bf24a2b into dashpay:develop Aug 1, 2024
@UdjinM6 UdjinM6 added this to the 21.2 milestone Sep 6, 2024
@UdjinM6 UdjinM6 modified the milestones: 21.2, 22 Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@knst knst knst approved these changes

@PastaPastaPasta PastaPastaPasta PastaPastaPasta left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

22

Development

Successfully merging this pull request may close these issues.

3 participants

@UdjinM6 @knst @PastaPastaPasta